1914602 - Stop preloading Mozilla DLLs for WMF software encoding in content process

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect)

Description

[Yannis Juglaret [:yannis]]

We currently preload these DLLs in all content processes, which presumably has some performance impact. We did this in bug 1910861 to mitigate the crashes with ESET from bug 1905690 - but ESET has since then pushed new changes that perhaps will fix the crashes. If not, we want to mitigate the crashes in another way that does not involve preloading the DLLs in all content processes.

Comment 1

[Yannis Juglaret [:yannis]]

Attachment: Bug 1914602 - Stop preloading Mozilla DLLs for WMF software encoding in content process. r=bobowen

We currently preload these DLLs in all content processes, which
presumably has some performance impact. We did this in bug 1910861 to
mitigate the crashes with ESET from bug 1905690 - but ESET has since
then pushed new changes that perhaps will fix the crashes. If not, we
want to mitigate the crashes in another way that does not involve
preloading the DLLs in all content processes.

Comment 2

[Yannis Juglaret [:yannis]]

As explained by :bobowen in the code review, we already allow access to the bin directory so we can actually just completely stop preloading.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910861

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15521da2b145
Stop preloading Mozilla DLLs for WMF software encoding in content process. r=bobowen

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1905690#c31 it sounds like you may want to request uplift to beta, but the last beta build for 130 is happening today. So if this is something you think should be in 130 beta/release, please talk with :ryanvm. It may be something to keep an eye on for the RC build or a dot release later.

Comment 6

[Yannis Juglaret [:yannis]]

Attachment: Bug 1914602 - Stop preloading Mozilla DLLs for WMF software encoding in content process.

We currently preload these DLLs in all content processes, which
presumably has some performance impact. We did this in bug 1910861 to
mitigate the crashes with ESET from bug 1905690 - but ESET has since
then pushed new changes that perhaps will fix the crashes. If not, we
want to mitigate the crashes in another way that does not involve
preloading the DLLs in all content processes. Preloading is not required
even with sandbox level 8, because we already allow access to the bin
dir anyway.

Original Revision: https://phabricator.services.mozilla.com/D219961

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Potential performance impact at each content process startup
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: Low
• Explanation of risk level: The patch restores the behavior found in versions 129 and below.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Yannis Juglaret [:yannis]]

Thanks :lizzard, I'll see with :RyanVM.

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/15521da2b145

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd1af22f8775