Closed
Bug 1914723
Opened 5 months ago
Closed 4 months ago
Remove NS_ProxyRelease for storage Variant
Categories
(Core :: SQLite and Embedded Database Bindings, defect, P2)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
132 Branch
| Tracking | Status | |
|---|---|---|
| firefox132 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
Bug 874814 introduced a proxyrelease on mParamsArray because of XPCVariant being passed into Storage, though one year later in Bug 1005991 I converted those XPCVariant into Storage Variant, that should be thread-safe.
This means we can likely MOZ_DIAGNOSTIC_ASSERT that we don't have an XPCVariant, and remove the proxy release.
This should save quite a few runnables that are just being posted to the main-thread to release these objects.
|
Assignee | |
Comment 1•5 months ago
|
||
|
||
Updated•5 months ago
|
Attachment #9420745 -
Attachment description: WIP: Bug 1914723 - Remove NS_ProxyRelease for storage Variant → Bug 1914723 - Remove no longer necessary proxy release for Storage variants. r=asuth
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/412c10e2e7ca
Remove no longer necessary proxy release for Storage variants. r=asuth
|
||
Comment 3•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•