1914735 - color-scheme with different single values does not work for consecutive elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Roman Komarov]

Attachment: CodePen - Firefox color-scheme bug.html

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.5666.197 Safari/537.36

Steps to reproduce:

1. Open https://codepen.io/kizu/pen/eYwrPXP (or open the attached .html)
2. Look at the elements on the page.
3. Delete or comment out the first div.

Actual results:

Before deletion of the first div, the color-scheme is applied incorrectly for the elements with the “Always dark” text: the color: CanvasText is applied, but the background and border are using the incorrect color-scheme.

After deletion/commenting out the first div it inverts: now the “Always light” is buggy.

Expected results:

The “Always light” and “Always dark” elements should have their color-scheme always correctly applied, regardless of their order.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Thanks for the excellent test-case Roman :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1914735 - Track color-scheme dependencies for non-inherited rule cache. r=#style,#layout

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4075eab1fdc4
Track color-scheme dependencies for non-inherited rule cache. r=firefox-style-system-reviewers,boris

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47967 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: error: missing documentation for a struct field
  error: could not compile style (lib) due to 1 previous error
  make[4]: *** [force-cargo-test-run] Error 101

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c30c633bc68b
Track color-scheme dependencies for non-inherited rule cache. r=firefox-style-system-reviewers,boris

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c30c633bc68b

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot