1914826 - Top of screen cut off when exiting full screen

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Firefox Reporter]

Steps to reproduce:

Tested in nightly 131.0a1

1. Enable the "secret settings" menu, and use it to uncheck (disable) "Enable Navigation Toolbar"
2. Visit any website that has the functionality to enter full screen. Example: https://www.youtube.com/watch?v=EngW7tLk6R8
3. Enter full screen, on youtube press the full screen button to make a video full screen
4. Exit full screen.

Actual results:

The top of the screen is cut off, by about the amount of space the "navigation toolbar" would have taken up if it were showing at the bottom of the screen.

Expected results:

The top of the screen should not be cut off after exiting full screen.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[eclaudiu64]

Can you attach a sky record with this error? what phone model are you using?

Comment 3

[eclaudiu64]

This error is visually visible when exiting full screen from the video, it happens very quickly and I noticed it.

Comment 4

[eclaudiu64]

Attachment: mobizen_20240826_091138.mp4

And at the beginning of video input in full screen you see something like a trace on the screen, but when you exit full screen you see a trace from the keyboard, I think.

Comment 5

[Chris Peterson [:cpeterson]]

Actual results:

The top of the screen is cut off, by about the amount of space the "navigation toolbar" would have taken up if it were showing at the bottom of the screen.

eclaudiu64, can you please attach a screenshot (or share the video timestamp) of the moment the top of the screen is cut off? I can't tell when watching the video.

Is this bug reproducible in Fx Beta 130? Since this bug happens when Nightly's new toolbar is disabled, I'm worried this is a regression that we will ship to release users.

Comment 6

[Firefox Reporter]

I have the address bar on the top. I see you attached a video somehow but I don't see how to do that here.

https://www.youtube.com/watch?v=GpebWfYj_M0

Device is Google Pixel 3a XL, on Android 9.

Comment 7

[Firefox Reporter]

In case it is not clear in the video, after exiting full screen the youtube black bar at the top of the screen (has the logo and the search icon) are cut off. This problem persists even if I refresh the page. If I use the address bar to navigate to a new website, the problem fixes itself. I have reproduced on multiple websites that enter fullscreen, not just youtube and not just videos.

Comment 8

[Firefox Reporter]

Yes, I just installed Firefox Beta, moved the address bar to the top. The issue still occurs there. With the address bar on the bottom, the issue does not present itself.

Comment 9

[eclaudiu64]

Sorry, I attached another error, I will post a new bug. In this error I think the author is saying that the bar where the logged in account is, the logo , etc disappears after exiting a full screen video.

Comment 10

[Mira Lobontiu (Android QA)]

Attachment: slow motion.mp4

Thank you for the report!
I was not able to detect the issue.
I've tested on the latest Fenix Nightly 131.0a1 from 8/30 with a Samsung Galaxy Note 8 (Android 9), Xiaomi Mi8 Lite (Android 10), and a Google Pixel 6 (Android 15).

The only difference between Fenix and Chrome, is that on Fenix the toolbar is displayed when exiting fullscreen, and on Chrome it doesn't. Is this the issue?

PS: from the .mp4 uploaded by the reporter, I was not able to observe the cut-off.

Comment 11

[Firefox Reporter]

I was able to reproduce on another phone.

Samsung Galaxy S20, Android 13.

It appears "Scroll to hide toolbar" also needs to be disabled.

In summary

1. In "Customize" menu, set "Address bar location" to "Top".
2. In "Customize" menu, disable "Scroll to hide toolbar".
3. In "Secret Settings" menu, disable "Enable Navigation Toolbar".

Comment 12

[Chris Peterson [:cpeterson]]

Attachment: screenshot_with_missing_YouTube_header.png

Thanks for your patience and the new recording. Roger can reproduce the bug now. In this screenshot (of the recording), you can see that YouTube's header is hidden behind Firefox's address bar. The video is flush with the address bar, but should be lower.

This issue is only reproducible when the dynamic toolbar hiding is disabled.

Comment 13

[Chris Peterson [:cpeterson]]

This bug is a navbar beta blocker.

Comment 14

[Mike a [:mavduevskiy]]

Attachment: Bug 1914826 - Fix top margin during fullscreen rotation for static toolbar

reinitializeEngineView called inside fullScreenChanged would be picking up the wrong value from the fullScreenFeature, as the feature would updated the value after the callback is executed. hense, propogating the value from the fullScreenChanged callback into the reinitializeEngineView directly.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d7dbd351ded
Fix top margin during fullscreen rotation for static toolbar r=android-reviewers,Roger

Comment 16

[Mike a [:mavduevskiy]]

Attachment: Bug 1914826 - Fix vertical spacing after exiting fullscreen (video) mode

einitializeEngineView called inside fullScreenChanged would be picking up the wrong value from the fullScreenFeature, as the feature would updated the value after the callback is executed. hense, propogating the value from the fullScreenChanged callback into the reinitializeEngineView directly.

Comment 17

[Mike a [:mavduevskiy]]

Comment on attachment 9424742 [details]
Bug 1914826 - Fix vertical spacing after exiting fullscreen (video) mode

sorry, wrong bug
–

Comment 18

[Phabricator Automation]

Comment on attachment 9424742 [details]
Bug 1914826 - Fix vertical spacing after exiting fullscreen (video) mode

Revision D222164 was moved to bug 1917932. Setting attachment 9424742 [details] to obsolete.

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9d7dbd351ded

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mavduevskiy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 21

[Mike a [:mavduevskiy]]

Attachment: Revert "Bug 1914826 - Fix top margin during fullscreen rotation for static toolbar"

This reverts commit 76e0a515b9cca31320821b00de4fca3e5ed24457. As a side effect, bug 1919706 fixed bug 1914826 in a cleaner way. Reverting this patch will make code around fullscreen transitions less confusing.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a2d7045566a
Revert "Bug 1914826 - Fix top margin during fullscreen rotation for static toolbar" r=android-reviewers,Roger