191483 - bugs in intl/uconv/src/nsUnicodeToUTF8.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

I saw several bugs in this file 

110     if ( *src < 0x007f) {
Isn't it true this should be either

110     if ( *src <= 0x007f) {
or
110     if ( *src < 0x0080) {

Isn't the following line 
115     } else if (*src < 0x07ff) {
should be
115     } else if (*src <= 0x07ff) {
or
115     } else if (*src < 0x0800) {

I think the following is defintely wrong
121     } else if (*src >= (PRUnichar)0xD800 && *src < (PRUnichar)0xDA00) {
it should be
121     } else if (*src >= (PRUnichar)0xD800 && *src < (PRUnichar)0xDC00) {

right? where the DA00 come from ?

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Patch with ftang's fixes

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 124483 [details] [diff] [review]
Patch with ftang's fixes

r=smontagu. Thanks for picking this up!

Comment 3

[rbs]

Comment on attachment 124483 [details] [diff] [review]
Patch with ftang's fixes

sr=rbs (I would have preferred the <= variant, as it is more readable and saves
the reader from guessing.)

Comment 4

[Simon Montagu :smontagu]

Fix checked in (in <= form)

Comment 5

[Bernard Alleysson]

This is a simple fix that looks good and I think that this is important to have
an absolutly correct conversion from Unicode to UTF8 for Mozilla 1.4 
Reporter and assignee should comment on the value and risk of this fix.

I don't know whether I should request approval1.4 for the patch or set blocking
1.4? but I'm asking that this patch is checked in on the 1.4 branch

Comment 6

[Asa Dotzler [:asa]]

mozilla1.4 shipped. unsetting blocking1.4 request.