1914837 - Refactor DesktopDeviceInfo

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task)

Description

[Andreas Pehrson [:pehrsons]]

This code is old, and I think it is originally from libwebrtc where it was deleted at some point. We undeleted it and moved it to dom/media/systemservices. It looks a lot like C-code with low-level string handling and manual new/free and raw pointer shuffling.

There is also a lot of code duplication we could get rid of in that screen/window/tab info are largely the same.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1914837 - Simplify DesktopDeviceInfo and friends. r?#webrtc-reviewers

This removes a lot of duplicate code with some help from templates.
It also brings the code in DesktopDisplayDevice and DesktopTab into the realm of
C++.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1914837 - Always initialize DesktopCapturer::pid. r?#webrtc-reviewers

This member is patched on top of libwebrtc. New backends could be added from
under us. It needs to be initialized.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8033ee35e2d0
Simplify DesktopDeviceInfo and friends. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/fdf5b0a81b0c
Always initialize DesktopCapturer::pid. r=webrtc-reviewers,ng

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8033ee35e2d0
https://hg.mozilla.org/mozilla-central/rev/fdf5b0a81b0c

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1914837 - Simplify DesktopDeviceInfo and friends.

This removes a lot of duplicate code with some help from templates.
It also brings the code in DesktopDisplayDevice and DesktopTab into the realm of
C++.

Original Revision: https://phabricator.services.mozilla.com/D220264

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1914837 - Always initialize DesktopCapturer::pid.

This member is patched on top of libwebrtc. New backends could be added from
under us. It needs to be initialized.

Original Revision: https://phabricator.services.mozilla.com/D220265

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/428e89f77864
https://hg.mozilla.org/releases/mozilla-esr128/rev/8d958288c13b