1914912 - Busy spinner not displayed in “Scan in progress” dialog

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: busy spinner not displayed

Found in

• 131.0a1 (2024-08-25)

Affected versions

• 131.0a1

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• Run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

Tested platforms

• Affected platforms: Windows 11
• Unaffected platforms: Ubuntu, macOS

Steps to reproduce

1. Navigate to https://www.wikipedia.org/ and paste any text
2. Observe the “Scan in progress” dialog

Expected result

• The busy spinner is displayed next to the “Scan in progress” title

Actual result

• The busy spinner is not displayed next to the “Scan in progress” title

Regression range

• Last good build: 2024-08-21
• First bad build: 2024-08-22
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3a7c34ad2ef66c1e404ec60eb62950e85a73fa65&tochange=530841552078c7f20e178e552dc6d2f400bbafb7
• Potentially regressed by: 1879550

Additional notes

• See the attached ss
• Reproducing for the upload operation as well

Comment 1

[Greg Stoll :gstoll]

Note that this won't be a problem for ESR since the regressing bug 1879550 won't be uplifted there.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1879550

:Gijs, since you are the author of the regressor, bug 1879550, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1914912 - re-show icons in tab-modal prompts that bug 1879550 accidentally broke, r?dao

Comment 4

[:Gijs (he/him)]

Well, this is embarrassing.

The issue is that I forgot to update https://searchfox.org/mozilla-central/rev/261005fcc4d6f8b64189946958211259fb45e9e1/toolkit/components/prompts/content/commonDialog.js#41 after the rename. This breaks icons in all tab-modal prompts (but not content-modal prompts, which is probably why nothing else picked up on this) because we no longer think we have an icon so we hide the box containing the icon...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67a77d66d0e8
re-show icons in tab-modal prompts that bug 1879550 accidentally broke, r=dao

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/67a77d66d0e8

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox 131.0b4 using Windows 11. The busy spinner is displayed inside the "Scan in progress" dialog.