1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell

Status: RESOLVED FIXED

(DevTools :: General, task)

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell

This was added in bug 1275942 which added the --wait-for-jsdebugger option.
I think it's not necessary because BrowserGlue.sys.mjs is loaded before
"command-line-handler" category runs[1], so the first window will have already
opened before DevToolsStartup.handleDebuggerFlag spins the event loop[2]

[1] https://searchfox.org/mozilla-central/rev/3f193a8bb0759058c2f9a9d7761ad73bc6ffd4b1/toolkit/xre/nsAppRunner.cpp#5571-5573,5734-5737
[2] https://searchfox.org/mozilla-central/rev/1d4c27f9f166ce6e967fb0e8c8d6e0795dbbd12e/devtools/startup/DevToolsStartup.sys.mjs#1011,1037-1043

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e04c427060e1
Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/e04c427060e1

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing OS X mochitests failures in browser_startup.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | should have no unexpected modules loaded before profile selection - Got 1, expected +0

Comment 5

[Gregory Pappas [:gregp]]

hmm, I guess the failure is happening because we're unconditionally loading xulstore on macOS now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ece61c7f15c
Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7ece61c7f15c