Closed Bug 1915082 Opened 2 months ago Closed 2 months ago

Request sRGB colorspace from ScreenCapturerSck

Categories

(Core :: WebRTC: Audio/Video, task)

Unspecified
macOS
task

Tracking

()

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

The ScreenCaptureKit docs say:

If you don’t specify a value, the output buffer uses the same color space as the display.

But our desktop capture framework assumes BGRA (naming channel order convention varies by platform) with no particular color space handling and libyuv assumes sRGB by default for RGB. Note in newer libyuv (vendored) you can provide your own matrix to convert from any color space.

Was confused by the yuv colorspaces for a bit and forgot to change back.

Summary: Request BT.601-limited colorspace from ScreenCapturerSck → Request sRGB colorspace from ScreenCapturerSck
Attached image Display P3
Attached image sRGB

The desktop capture path has no colorspace handling for RGB, and libyuv assumes
sRGB by default. ScreenCaptureKit returns frames in the display's colorspace
unless told otherwise. On modern macs this is 'Display P3' and will render
inaccurately when interpreted as sRGB.

Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6f6acc479b37 From ScreenCapturerSck request frames in sRGB colorspace. r=webrtc-reviewers,ng
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: