1915082 - Request sRGB colorspace from ScreenCapturerSck

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task)

Description

[Andreas Pehrson [:pehrsons]]

The ScreenCaptureKit docs say:

If you don’t specify a value, the output buffer uses the same color space as the display.

But our desktop capture framework assumes BGRA (naming channel order convention varies by platform) with no particular color space handling and libyuv assumes sRGB by default for RGB. Note in newer libyuv (vendored) you can provide your own matrix to convert from any color space.

Comment 1

[Andreas Pehrson [:pehrsons]]

Was confused by the yuv colorspaces for a bit and forgot to change back.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Display P3

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: sRGB

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1915082 - From ScreenCapturerSck request frames in sRGB colorspace. r?#webrtc-reviewers!

The desktop capture path has no colorspace handling for RGB, and libyuv assumes
sRGB by default. ScreenCaptureKit returns frames in the display's colorspace
unless told otherwise. On modern macs this is 'Display P3' and will render
inaccurately when interpreted as sRGB.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f6acc479b37
From ScreenCapturerSck request frames in sRGB colorspace. r=webrtc-reviewers,ng

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6f6acc479b37

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1915082 - From ScreenCapturerSck request frames in sRGB colorspace.

The desktop capture path has no colorspace handling for RGB, and libyuv assumes
sRGB by default. ScreenCaptureKit returns frames in the display's colorspace
unless told otherwise. On modern macs this is 'Display P3' and will render
inaccurately when interpreted as sRGB.

Original Revision: https://phabricator.services.mozilla.com/D220219

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/4f3a57903494