1915122 - Scrolling height wrong when toolbar top, no navbar and a microsurvey is displayed

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, defect, P1)

Description

[twhite]

Attachment: toolbar top no navbar microsurvey scroll bug.mp4

Steps to reproduce

1. Disable new navbar
2. Navigate to webpage
3. Use the 'print' feature to trigger microsurvey
4. Scroll the webpage

Expected behavior

The toolbar and microsurvey scroll out of view and the webpage content fills the space.

Actual behavior

The toolbar and microsurvey scroll out of view, but the webpage content has a gap at the top.

Comment 1

[twhite]

Attachment: Bug 1915122 - Fix scrolling height wrong when toolbar top, no navbar and a microsurvey is displayed

Comment 2

[twhite]

Attachment: toolbar top no navbar microsurvey scroll fix.mp4

Comment 3

[twhite]

Attachment: Bug 1915122 - Fix scrolling height wrong when toolbar top, no navbar and a microsurvey is displayed

Original Revision: https://phabricator.services.mozilla.com/D220241

Comment 4

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Potenitally seeing a buggy UI with this particular app configuration
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug
• Risk associated with taking this patch: Low
• Explanation of risk level: Verified in dev - only triggered by a small percentage of users
• String changes made/needed: None
• Is Android affected?: no

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d24f4085a6e
Fix scrolling height wrong when toolbar top, no navbar and a microsurvey is displayed r=android-reviewers,vdreghici

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2d24f4085a6e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9420993 [details]
Bug 1915122 - Fix scrolling height wrong when toolbar top, no navbar and a microsurvey is displayed

130 is on release now. Moving the request over accordingly.

Comment 8

[Mira Lobontiu (Android QA)]

Attachment: az_recorder_20240829_115628.mp4

Verified as fixed on the Fenix Nightly 131.0a1 from 8/29 with Google Pixel 6 (Android 15), and Samsung Galaxy A14 (Android 13).
The toolbar and microsurvey scroll out of view, and the webpage content fills the space.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/1e067e807647

Comment 10

[Pascal Chevrel:pascalc (PTO until Sept 2)]

This fix will be included in our planned 130 dot release, thanks.

Comment 11

[Lorand Janos]

Verified the issue after triggering the Homescreen Microsurveys feature through Secret Settings the following way:

1. Enable "Use Nimbus Preview Collection"
2. Restart the app twice with activating the Secret Settings each time.
3. Go to Nimbus experiments>Microsurvey: Android Homepage CSAT 2024 Debugging> Enable the Survey.
4. Force close the app.
5. Open the app.

As the feature is only triggered on the Homepage, the steps to get there and the behavior is different, the Survey prompt does not scroll out of view, the homepage content has no gap at the top.

Verified on RC 130.0.1, using a Samsung Galaxy S23 Ultra (Android 14).

Comment 12

[Lorand Janos]

Attachment: Recorder_16092024_153204.mp4