1915127 - "Manage Extension Shortcuts" unable to detect conflicts with built-in shortcuts with control (Ctrl)

Status: NEW

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Rob Wu [:robwu]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1911798#c5 for details.

In short, ShortcutUtils.isShortcut fails to detect built-in shortcut conflicts with Ctrl because the extension internals maps extension-defined Ctrl to "accel", and that prevents the implementation from finding a match when another component of Firefox registers a shortcut for control.

To fix this, we should look for both "accel" and "control" when the modifiers contain "control" or "accel" at https://searchfox.org/mozilla-central/rev/490a1df802d8872f996f8ef4093d54e3c854c8f9/toolkit/modules/ShortcutUtils.sys.mjs#287-295

Comment 1

[Rob Wu [:robwu]]

Marking as P2 because the scope is clear and easy to fix: we should adjust the selector to also check for the control modifier in addition to accel modifier.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rpl, could you have a look please?

For more information, please visit BugBot documentation.