1915232 - Sidebar button can get into an inverted active state

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

In a recent Nightly with sidebar and vertical tabs enabled:

1. Click on the sidebar button to expose the full sidebar
2. Click on the sidebar button again to collapse the sidebar.

ER:

The sidebar button after step 2 should be in the inactive state.

AR:

The sidebar button is still in the active state for me. Clicking it again opens the sidebar up and puts the button into the inactive state, which I suspect is the reverse of what we want.

Comment 1

[Kestrel]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=92acbb3b404d41b2fc9a3f5307603d42b70f31fa&tochange=38cc8fd863bbc1136b6a5cc54deaa743e5f1e2ff

Regressed by Bug 1898251.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1898251

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1915232 - Fix for sidebar toolbar button inverted state

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f20f138ea4ac
Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_history_sidebar.js.

• Backout link
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_history_sidebar.js | There is a card for each day. - 2 == 3 -

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deeedc530652
Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley

Comment 7

[Serban Stanca [:SerbanS]]

Relanded this because it doesn't seem to be the culprit.

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/deeedc530652

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 131.0a1 (2024-08-30) on Ubuntu 24.04 by following the STR from Comment 0.

The issue is fixed on Firefox 132.0a1 (2024-09-04). Tests were performed on Windows 11, Ubuntu 24.04 and macOS 14.6.1.