1915273 - Always show Revert Button while in Persisted Search Mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[James Teow [:jteow]]

We have a couple outstanding issues related to accessibility with Persisted Search especially now that it combines usage with the Unified Search Button

• Tabbing skips the Unified Search Button
• It's impossible to select the revert urlbar button because tabbing only selects the input which then hides the other options

Comment 1

[James Teow [:jteow]]

After talking with Josh, we agreed we should always show the Revert Button, including if the address bar is focused. When the search terms change, the revert button can disappear in favor of the non-focusable "Go" (Arrow) button.

Similar to the decision to always show the Unified Search Button, this will allow for more predictable behaviour when using the keyboard to navigate to the button and thus, make it more accessible. Additionally, pressing the revert button should focus the urlbar so that users who need to use the keyboard don't have to re-tab all the way back to the input.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1915273 - Allow revert button to always show until search terms change and fix keyboard focus - r?adw!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32bd1ca060be
Allow revert button to always show until search terms change and fix keyboard focus - r=adw,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/32bd1ca060be