1915350 - Web pages become unresponsive after pasting the “warning text”

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: warning - webpage unresposive

Found in

• 131.0a1 (2024-08-27)

Affected versions

• 131.0a1

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• Run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

Tested platforms

• Affected platforms: Windows 10/11
• Unaffected platforms: Ubuntu, macOS

Steps to reproduce

1. Go to https://drive.google.com/drive/home/https://onedrive.live.com/login/ and sign in
2. Open up a document in an external program (for example Notepad) and type “warning text” into it and copy it (or in any text field from a different tab)
3. Go back to Google Drive/OneDrive and open a Google Docs/Word document
4. Paste the “warning text” and select any option from the Warn dialog
5. Observe the behavior

Expected result

• Based on the selected option the content gets pasted or not. The page does not become unresponsive

Actual result

• The page becomes unresponsive after selecting an option from the Warn dialog

Regression range

• Last good build: 2024-08-21
• First bad build: 2024-08-22
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0f83f459abf3f6588e42aa71b222cda02a94b6c&tochange=d906de157f374a6bc8f03790b7bf8832b69e3fe0
• Potentially regressed by: 1912384

Additional notes

• See the attached video
• If having other Google Docs opened in different tabs, they become blank and do not recover until closed
• Also reproducing if pasting the “warning text” on random websites multiples times in a row

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1912384, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

OK, I think the problem is that the cache needs to record the user's choice after returning WARN, not the WARN result itself.

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 1915350: cache the final Content Analysis response for WARN results r=#dlp-reviewers!

Instead of caching the fact that the DLP Agent returned WARN, cache
whether the user chose to ALLOW or BLOCK. This is more helpful, and
apparently was causing hangs.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1912384

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97087fc4f0d7
cache the final Content Analysis response for WARN results r=dlp-reviewers,handyman

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/97087fc4f0d7

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gstoll, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Greg Stoll :gstoll]

Not going to uplift to beta but planning on doing so to ESR128 after this bug is verified.

Comment 9

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox Nightly 132.0a1 (2024-09-10) using Windows 10/11. Web pages are no longer unresponsive after pasting the “warning text” when following the steps described in Comment 0.
However, we logged a new issue similar to this. See bug 1918028.

Comment 10

[Greg Stoll :gstoll]

Attachment: Bug 1915350: cache the final Content Analysis response for WARN results r=#dlp-reviewers!

Instead of caching the fact that the DLP Agent returned WARN, cache
whether the user chose to ALLOW or BLOCK. This is more helpful, and
apparently was causing hangs.

Original Revision: https://phabricator.services.mozilla.com/D220464

Comment 11

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: avoid hangs in DLP with WARN responses
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a, will be covered as a part of the general DLP test plan
• Risk associated with taking this patch: low
• Explanation of risk level: minor change to DLP
• String changes made/needed: no
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/a7758daafcc8

Comment 13

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed on Firefox 128.3.0esr using Windows 11. Web pages are no longer unresponsive after pasting the “warning text” when following the steps described in Comment 0.