1915354 - Perma [DON'T USE FOR CLASSIFICATION] TypeError: string argument expected, got 'bytes'

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=472026936&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/F1bwC1o_Sk6z0NnW2jZziA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -  HEY! If you're reading this, you're about to encounter a type error, probably as a result of a conversion from Python 2 to Python 3. This is almost definitely because you're trying to write binary data to a text-encoded stream, or text data to a binary-encoded stream. Check how you're instantiating your ProcessHandler and if the output should be text-encoded, make sure you pass universal_newlines=True.
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -  Traceback (most recent call last):
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -    File "D:\task_172480899344158\build\venv\Lib\site-packages\mozprocess\processhandler.py", line 1128, in _read
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -      callback(line.rstrip())
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -    File "D:\task_172480899344158\build\venv\Lib\site-packages\mozprocess\processhandler.py", line 1036, in __call__
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -      e(*args, **kwargs)
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -    File "D:\task_172480899344158\build\venv\Lib\site-packages\mozprocess\processhandler.py", line 1178, in __call__
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -      self.stream.write(ensure(line, errors="ignore") + ensure("\n"))
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -    File "<frozen codecs>", line 378, in write
[task 2024-08-28T01:42:19.472Z] 01:42:19     INFO -  TypeError: string argument expected, got 'bytes'

Comment 1

[Mike Hommey [:glandium]]

This looks like something that was wrong before bug 1906191 was made worse. I'm trying to determine where this is coming from.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1906191

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1915354 - Don't create invalid text streams off sys.stdout.

While here, avoid wrapping sys.stdout when it's already encoded to
utf-8.

Comment 4

[Intermittent Failures Robot]

18 failures in 780 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 6
• autoland: 11
• try: 1

Platform and build breakdown:

• windows11-64-2009-ccov-qr: 2
  • opt: 2
• linux1804-64-qr: 9
  • debug: 8
  • opt: 1
• windows11-32-2009-qr: 4
  • debug: 3
  • opt: 1
• linux1804-64-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1915354&startday=2024-08-28&endday=2024-08-28&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51b2cd490529
Don't create invalid text streams off sys.stdout. r=webdriver-reviewers,whimboo

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/51b2cd490529

Comment 7

[Intermittent Failures Robot]

2 failures in 3879 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• autoland: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1
• windows11-32-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1915354&startday=2024-08-26&endday=2024-09-01&tree=all

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/20d50017b0a5