1915362 - Implement partial history collection for better performance on history state updates

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Kaya [:kaya]]

Currently on Android, we are not exercising partial history collection and we do a full collection all the time. This is not optimal, perf-wise.
While moving on with SHIP on Android, we can consider enabling the partial history collection as well.

Linking a crash ticket as well, which was caused by the lack of partial history collection. The current SHIP code behaves as if there's partial history change updates on the client end (GeckoSession.SessionState cache), but indeed, there is not. That's why when SHIP is enabled, the history items are fully overriden when it was supposed to be a partial update which reduces the history items size and keeps the index same, and as a result ends up with an IndexOutOfBounds exception.
No-SHIP codepath always collects the history fully, that's why it is not an issue there.

Comment 1

[Kaya [:kaya]]

Attachment: Bug 1915362 - Enable partial history collection for better performance on history state updates on Android.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5812ac11caa3
Enable partial history collection for better performance on history state updates on Android. r=geckoview-reviewers,owlish

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5812ac11caa3