1915369 - about:networking#sockets UDP Sent and Received is 0 with network.http.http3.use_nspr_for_io false

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Max Inden]

When Nightly only network.http.http3.use_nspr_for_io is set to false then about:networking#sockets Sent and Received is 0 for UDP for HTTP/3 QUIC UDP sockets.

Note that network.http.http3.use_nspr_for_io is only set to false on Firefox Nightly. Thus this regression only affects Firefox Nightly.

https://searchfox.org/mozilla-central/rev/45d6f8bf028e049f812aa26dced565d50068af5d/modules/libpref/init/StaticPrefList.yaml#13655-13666

I will follow-up with a patch in a bit.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Thanks!

Comment 2

[Max Inden]

Attachment: Bug 1915369 - track bytes sent and received when using quinn-udp r=kershaw

An nsIUDPSocket tracks the number of bytes sent and received through its
methods, e.g. RecvWithAddr. The number of bytes is then displayed in
about:networking#sockets.

With network.http.http3.use_nspr_for_io set to false Http3Session uses
quinn-udp instead of NSPR for HTTP/3 QUIC UDP IO. Thus it does not use
nsIUDPSocket RecvWithAddr, but instead optains a raw file descriptor via
nsIUDPSocket GetFileDescriptor and then does its IO directly. Thereby the
number of bytes sent and received in nsIUDPSocket are not updated, i.e. stay
at 0.

This commit exposes two new methods in nsIUDPSocket, namely addOutputBytes
and addInputBytes which are each called after any IO operation on the raw file
descriptor optained through nsIUDPSocket GetFileDescriptor.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1901295

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b612ce84cf9
track bytes sent and received when using quinn-udp r=necko-reviewers,valentin

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7b612ce84cf9