1915382 - inspector-shared.css and inspector-color-swatches.css could be refactored

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Mose of the classes are prefixed with ruleview, but they are now also used in the tooltip, so we might switch this to inspector instead.

Color swatch rule is setting top/right/bottom/left where we could use inset
we could also use css variables to avoid repeating some values

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915382 - [devtools] Refactor ruleview-colorswatch CSS rule. r=itiel.

Use inset and variables.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915382 - [devtools] Replace ruleview prefix with inspector in inspector shared CSS files. r=#devtools-reviewers.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915382 - [devtools] Migrate --rule-highlight-background-color to inspector-shared.css and rename it. r=#devtools-reviewers.

The variable is being used in inspector-swatches.css,
so it should be set in a shared stylesheet too.
The highlight of shape points on hover was broken,
so I took the opportunity to fix it here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84e58343d8eb
[devtools] Refactor ruleview-colorswatch CSS rule. r=Itiel,devtools-reviewers.
https://hg.mozilla.org/integration/autoland/rev/114997492b00
[devtools] Replace ruleview prefix with inspector in inspector shared CSS files. r=devtools-reviewers,jdescottes.
https://hg.mozilla.org/integration/autoland/rev/da2176c13494
[devtools] Migrate --rule-highlight-background-color to inspector-shared.css and rename it. r=devtools-reviewers,ochameau.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/84e58343d8eb
https://hg.mozilla.org/mozilla-central/rev/114997492b00
https://hg.mozilla.org/mozilla-central/rev/da2176c13494