1915434 - Telemetry adjustments for add image flow in PDFs (again)

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

• pdfjs.image.alt_text.image_status_label_displayed: I'm seeing the event twice between clicking add image and image added, but if I click on the image later I don't see the event. I'd expect it to show only at the end of the image add flow and when the user clicks on image afterwards.
• we must add a new event pdfjs.image.alt_text.ai_generation_check with an extra key status which is a boolean indicating if the alt text is guessed thanks to ML.
• pdfjs.image.alt_text_edit must be updated each time the user changes the setting.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Fix few telemetry issues with the new alt text flow (bug 1915434) (#18661)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1915434 - Make some telemetry adjustments for the new alt text flow r=#pdfjs-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6f87ee10c50
Make some telemetry adjustments for the new alt text flow r=pdfjs-reviewers,Snuffleupagus

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f6f87ee10c50

Comment 5

[Calixte Denizet (:calixte)]

Attachment: Bug 1915434 - Make some telemetry adjustments for the new alt text flow

Original Revision: https://phabricator.services.mozilla.com/D220463

Depends on D220881

Comment 6

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Low
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check that metrics defined in comment#0 are correcly updated
• Risk associated with taking this patch: low
• Explanation of risk level: Limited to the pdf.js scope and updates telemetry stuff
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[Rares Doghi, Desktop QA]

Hi @Calixte is the pdfjs.image.alt_text_edit = pdfjs.image.alt_text.settings_edit_alt_text_check because I cant seem to find "pdfjs.image.alt_text_edit" anywhere and when I do change the Alt Text editor from Settings I get this one "pdfjs.image.alt_text.settings_edit_alt_text_check"

Comment 8

[Calixte Denizet (:calixte)]

:Rares, it should be something like altTextEdit.ai_generation and altTextEdit.ask_to_edit.
I'm not sure that they're the strings you expect to see, but it should look like that.
I tested them here:
https://searchfox.org/mozilla-central/rev/3b59c739df66574d94022a684596845cd05e7c65/toolkit/components/pdfjs/test/browser_pdfjs_alttext_telemetry.js#88-94
and I'd be very surprised to not find them in the glean data.

Comment 9

[Rares Doghi, Desktop QA]

Yes, So these are the Strings that show up in Glean: pdfjs.image.alt_text.ai_generation_check / pdfjs.image.alt_text.settings_edit_alt_text_check
Thanks !

Verified as fixed in our latest Beta 131.0b4 as well as our latest Nightly build.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/0eec394dd866

Comment 11

[Pascal Chevrel:pascalc]

This fix will be included in our planned 130 dot release, thanks.

Comment 12

[Rares Doghi, Desktop QA]

This is verified as fixed in our latest Release 130.0.1 20240912074333