1915437 - [wpt-sync] Sync PR 47843 - Remove feature LCPMultipleUpdatesPerElement

Status: RESOLVED FIXED

(Core :: DOM: Performance, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47843 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47843
Details from upstream follow.

Hao Liu <[e-mail]> wrote:

Remove feature LCPMultipleUpdatesPerElement

This feature is to make the same element an LCP candidate again if it's
updated. It is added by this CL https://crrev.com/c/3924764. The
feature is never launched. We decided to remove it.

The CL that added this features seems only makes text layout objects
eligible for LCP by short-circuiting the already-seen check. Images
are not touched, although the commit msg seems to hint otherwise.

This CL removes the short-circuiting and modified the wpt.

Bug: 350536101
Change-Id: If0cb6ab99b488c1cc6ec7aff5ec3545ada49d39f
Reviewed-on: https://chromium-review.googlesource.com/5781764
WPT-Export-Revision: 9a227f95fe9769e81d4f4e0f9e10cd925023b536

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=95c673ca940c3919c16ff9c9335fbc319ed775e1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/490886f6f8a2
[wpt PR 47843] - Remove feature LCPMultipleUpdatesPerElement, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/490886f6f8a2