1915447 - moz-phab's `test_package` is failing due to incorrect file naming conventions

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Connor Sheehan [:sheehan]]

See the test failure log, where it appears we generate the tarballs as mozphab-1.5.2.tar.gz, but then try to install them as MozPhab-1.5.2.tar.gz.

This is blocking new releases of moz-phab.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: circleci: dist tarballs use all-lowercase naming convention (Bug 1915447) r?ahochheiden,zeid

I'm not sure when this changed, but in the logs it is clear that the tarball is
created as mozphab-{version}.tar.gz, whereas our setup is looking for
MozPhab-{version}.tar.gz. Update to all-lowercase naming to unblock releasing
moz-phab.

Comment 2

[Connor Sheehan [:sheehan]]

This change also breaks the self-updater. Re-opening.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: updater: make package filenames lowercase before scanning for versions (Bug 1915447) r?zeid

Comment 4

[Connor Sheehan [:sheehan]]

(In reply to Connor Sheehan [:sheehan] from comment #2)

This change also breaks the self-updater. Re-opening.

Actually it only breaks the self-updater for those who are using pre-release versions of moz-phab, which is maybe 1-2 people who we can reach out to about updating. With D221053 applied to the next release, we should be okay here.