1915578 - fails to detect architectures where -latomic is needed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Simon McVittie]

Steps to reproduce:

Build SpiderMonkey JavaScript library (mozjs128, as used by gjs) on Debian armel (armv5te little-endian EABI softfloat).

Actual results:

"checking whether 64-bits std::atomic requires -latomic... do not know; assuming no"

(This happens when linking a 64-bit atomic operation without -latomic fails, but linking the same code with -latomic also fails. Perhaps this should be a fatal error?)

Expected results:

The build system should be able to detect that -latomic is required.

Comment 1

[Simon McVittie]

This seems to be a bug in the detection code. When it tries to link with arguments that end with ["-latomic"], a single string is passed where a sequence of strings is expected, so what actually happens is that it tries to link with arguments that end with ["-", "l", "a", "t", "o", "m", "i", "c"] which is not going to work.

Comment 2

[Simon McVittie]

Attachment: 0001-build-Fix-detection-of-architectures-that-require-la.patch

proposed patch (I haven't verified that the whole build finishes successfully, but it does successfully detect that -latomic is required)

Comment 3

[Simon McVittie]

The build does succeed with the patch above. There are test failures, but they seem to be unrelated.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:sergesanspaille, since you are the author of the regressor, bug 1883940, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[[:sergesanspaille]]

Attachment: Bug 1915578 - Fix libatomic configure check r=glandium

Original patch by Simon McVittie <[e-mail]>

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883940

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6614a76198e9
Fix libatomic configure check r=glandium

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6614a76198e9

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sergesanspaille, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[[:sergesanspaille]]

Attachment: Bug 1915578 - Fix libatomic configure check

Original patch by Simon McVittie <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D220988

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Architecture requiring libatomic won't compile
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: run ./mach build and make sur it builds. If it fails on libatomic then we have an issue.
• Risk associated with taking this patch: None
• Explanation of risk level: tested on nightly and by the original bug reporter
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/45b3d0d954c3

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR128 also.

Comment 14

[[:sergesanspaille]]

Attachment: Bug 1915578 - Fix libatomic configure check

Original patch by Simon McVittie <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D220988

Comment 15

[[:sergesanspaille]]

Attachment: Bug 1915578 - Fix libatomic configure check

Original patch by Simon McVittie <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D220988

Comment 16

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Cannot build on some architecture (eg. armel)
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Build SpiderMonkey JavaScript library (mozjs128, as used by gjs) on Debian armel (armv5te little-endian EABI softfloat).
• Risk associated with taking this patch: none
• Explanation of risk level: tested on bookmarks/central
• String changes made/needed: no
• Is Android affected?: no

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/e2cb3d9c8cfc