Closed Bug 1915647 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 47863 - Make @import prelude parsed using the streaming parser.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47863 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47863
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Make @import prelude parsed using the streaming parser.

There is one exception still: If there's a media query in there,
it is still parsed using the non-streaming parser. However, the
supports part and the prelude in general are parsed streaming.

Note that this fixes a bug (also in the tests) where empty supports(),
or supports() with an invalid declaration inside, would be allowed;
there doesn't seem to be any allowance for this in the grammar
(\<general-enclosed> is not included in the @import grammar, only in
@supports).

Bug: 1500904
Change-Id: Ida837291feac344e847b0e3982acff9dd73c7d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5822594
Commit-Queue: Steinar H Gunderson \<sesse@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1348630}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 1 tests and 22 subtests

Status Summary

Firefox

OK : 1
PASS: 22

Safari

OK : 1
PASS: 22

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e048f42a187 [wpt PR 47863] - Make @import prelude parsed using the streaming parser., a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.