1915739 - Minimize browser UI for Taskbar Tab windows

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Nick Rishel [:nrishel]]

Tasbkar Tab windows should feature a minimal browser UI (while distinctly still remaining browser windows). For this we should disable all window chrome elements not relevant to Taskbar Tabs.

Comment 1

[Eric Chen]

Attachment: WIP: Bug 1915739 - Taskbar tabs demo

Comment 2

[Eric Chen]

Attachment: WIP: Bug 1915739 - [P1] Adding support for taskbar tabs UI r=nrishel!

Comment 3

[Eric Chen]

Attachment: WIP: Bug 1915739: [P1.1] Adding chrome flags for taskbar tabs chrome UI r=nrishel

Comment 4

[Eric Chen]

Attachment: Bug 1915739 - Part 1: Hide tab strip for taskbar tab windows. r=dao

Comment 5

[Eric Chen]

Attachment: Bug 1915739 - Part 3: Remove Fx Account toolbar button taskbar tab windows r=nrishel

Comment 6

[Eric Chen]

Attachment: Bug 1915739 - Part 4: Make URL bar read-only for taskbar tabs r=nrishel

Comment 7

[Eric Chen]

Attachment: Bug 1915739 - Part 5: Prevent window features from being restored for taskbar tab windows r=nrishel

Comment 8

[Eric Chen]

Attachment: Bug 1915739 - Part 6: Add an attribute to the top-level browser chrome element when opening a Taskbar Tab. r=mossop!

Comment 9

[Eric Chen]

Attachment: Bug 1915739 - Part 7: Add unit testing for taskbar tab chrome UI r=nrishel

Comment 10

[Eric Chen]

Attachment: WIP: Bug 1915739 add support for taskbar tab window objects r=nrishel

Comment 11

[Nick Rishel [:nrishel]]

Attachment: Bug 1915739 - Pre: Clarify logic for drawing to the title bar. r=dao

Comment 12

[Eric Chen]

Attachment: Bug 1915739 - Part 7: Add CSS ruleset to hide menubar and bookmark bar for Taskbar Tab windows r=nrishel!

Comment 13

[Eric Chen]

Attachment: Bug 1915739 - Part 2: Set up TaskbarTab UI module to disable appropiate UI components r=nrishel

Comment 14

[Nick Rishel [:nrishel]]

Attachment: Bug 1915739 - Pre 2: Modify and rename WindowFeature's `bool GetBoolWithDefault` to `Maybe<bool> MaybeGetBool`, moving default value handling out of the function. r=emilio

Comment 15

[Nick Rishel [:nrishel]]

Attachment: Bug 1915739 - Pre 4: Allow explicitly disabled window features to override catch-all chrome flags. r=emilio

Comment 16

[Nick Rishel [:nrishel]]

Attachment: Bug 1915739 - Pre 3: Consolidate default behavior for "titlebar" "close", "chrome", and "dialog". r=emilio

Additionally initial assignment of CHROME_OPENAS_DIALOG and CHROME_OPENAS_CHROME when aFeatures is empty and aDialog is true is redundant. This was handled at the end of the function, as it's trivially the case that aFeatures` being empty implies it does not contain either "chrome" or "dialog".

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a026cb2bdb0
Pre: Clarify logic for drawing to the title bar. r=dao,tabbrowser-reviewers
https://hg.mozilla.org/integration/autoland/rev/e544e69687d2
Part 1: Hide tab strip for taskbar tab windows. r=tabbrowser-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/c950f23528c5
Part 2: Set up TaskbarTab UI module to disable appropiate UI components r=sync-reviewers,firefox-desktop-core-reviewers ,Gijs,markh
https://hg.mozilla.org/integration/autoland/rev/9b4ee1b76c41
Part 3: Remove Fx Account toolbar button taskbar tab windows r=nrishel,desktop-theme-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/f867330ee9d7
Part 4: Make URL bar read-only for taskbar tabs r=nrishel,urlbar-reviewers,mak
https://hg.mozilla.org/integration/autoland/rev/5d73578cd3d2
Part 5: Prevent window features from being restored for taskbar tab windows r=sessionstore-reviewers,nsharpley
https://hg.mozilla.org/integration/autoland/rev/f94f8a216ae1
Part 6: Add an attribute to the top-level browser chrome element when opening a Taskbar Tab. r=firefox-desktop-core-reviewers ,mossop
https://hg.mozilla.org/integration/autoland/rev/99618abc1571
Part 7: Add unit testing for taskbar tab chrome UI r=nrishel

Comment 18

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7a026cb2bdb0
https://hg.mozilla.org/mozilla-central/rev/e544e69687d2
https://hg.mozilla.org/mozilla-central/rev/c950f23528c5
https://hg.mozilla.org/mozilla-central/rev/9b4ee1b76c41
https://hg.mozilla.org/mozilla-central/rev/f867330ee9d7
https://hg.mozilla.org/mozilla-central/rev/5d73578cd3d2
https://hg.mozilla.org/mozilla-central/rev/f94f8a216ae1
https://hg.mozilla.org/mozilla-central/rev/99618abc1571