1915774 - Stop using setFaviconForPage of head_common.js

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Daisuke Akatsuka (:daisuke)]

Many tests are using setFaviconForPage of head_common.js. But, as we stop using nsIFaviconService.setAndFetchFaviconForPage() in bug 1894633, the function came to simulate old behavior of setAndFetchFaviconForPage. As it hides API logic, we stop using this function, and then will do the old behavior in each tests.

Comment 1

[Marco Bonardo [:mak]]

The main concern here is many tests don't need to fetch from the database, and even less from the network.
So each test should just do what they effectively need.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915774: Remove setFaviconForPage() in head_common

Depends on D241764

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915774: Use PlacesTestUtils.setFaviconForPage() helper in places test

Depends on D241887

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/005ebb0e2753
Remove setFaviconForPage() in head_common r=places-reviewers,mak
https://hg.mozilla.org/integration/autoland/rev/c2623d0fa807
Use PlacesTestUtils.setFaviconForPage() helper in places test r=places-reviewers,mak

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/005ebb0e2753
https://hg.mozilla.org/mozilla-central/rev/c2623d0fa807