1915800 - Change modifier to add new line in Conditional panel

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, you can add a new line using Alt+Enter
In the console, you can add new lines with Shift+Enter, so we should be consistent

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

For what it's worth, Chrome also let you add new line on Shift+Enter

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915800 - [devtools] Add new line in conditional breakpoint panel on shift+Enter instead of alt+Enter. r=#devtools-reviewers.

This better matches what we do in the console inline mode.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915800 - [devtools] Select conditional breakpoint editor content. r=#devtools-reviewers.

This makes it easier to edit the expression.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1887bb182e2
[devtools] Add new line in conditional breakpoint panel on shift+Enter instead of alt+Enter. r=devtools-reviewers,ochameau.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a1887bb182e2

Comment 6

[Phabricator Automation]

Comment on attachment 9421791 [details]
Bug 1915800 - [devtools] Select conditional breakpoint editor content. r=#devtools-reviewers.

Revision D220683 was moved to bug 1915802. Setting attachment 9421791 [details] to obsolete.