1915811 - Revamped sidebar separator draws over the bookmarks toolbar when set to "Only Show on New Tab"

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Kestrel]

Attachment: Sidebar separator overlapping the bookmarks toolbar and address bar dropdown on Ubuntu

STR:

1. Start with sidebar.revamp = true.
2. Make sure the Bookmarks Toolbar is set to "Only Show on New Tab" (default).
3. Open a new tab.
4. Open the History sidebar (Ctrl+H).
5. Hover the mouse cursor over the sidebar separator.

Sidebar separator draws over the bookmarks toolbar.

Does not happen when the bookmarks toolbar is set to "Always Show".

On Ubuntu 24.04, the overlap is always visible without having to hover and it also overlaps the address bar dropdown.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=936f3047272d1ef5feb4f02953db3ad74c59bbd1&tochange=95109305b579922c59ef5966e60c9397e48847ac

Regressed by Bug 1910733.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910733

:nsharpley, since you are the author of the regressor, bug 1910733, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1915811 - Remove sidebar splitter z-index r=#sidebar-reviewers

This was added in Bug 1910733 but no longer needed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e51c001bdae9
Remove sidebar splitter z-index r=desktop-theme-reviewers,emilio

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e51c001bdae9

Comment 5

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 131.0a1 (2024-08-30) on Ubuntu 24.04 by following the STR from Comment 0.

The issue is fixed on Firefox 132.0a1 (2024-09-04). Tests were performed on Windows 11, Ubuntu 24.04 and macOS 14.6.1.