1915821 - Revamped sidebar animation leaves behind a ghost image of the page content when toggle clicked in quick succession

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[Kestrel]

Attachment: Ghost image after rapidly toggling sidebar

STR:

1. Start with sidebar.revamp = true.
2. Rapidly click the sidebar button in the toolbar to expand/collapse it.

A ghost image of the page content sometimes remains, covering the actual content. Dragging the image shows a drag thumbnail.

Occurs on both Ubuntu 24.04 and Windows 11.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=92acbb3b404d41b2fc9a3f5307603d42b70f31fa&tochange=38cc8fd863bbc1136b6a5cc54deaa743e5f1e2ff

Regressed by Bug 1898251.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1898251

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1898251, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1915821 - Remove all screenshots after sidebar expand/collapse animation

Comment 4

[Kelly Cochrane [:kcochrane]]

I was actually also able to reproduce this on mac eventually by spamming the toolbar button a bunch really fast.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b97e9376724
Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing OS X mochitests failures in browser_toolbarButtonKeyPress.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarButtonKeyPress.js | Uncaught exception in test bound testSidebarsButtonPress - Sidebar not expanded after press - timed out after 50 tries.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e436d03a013
Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4e436d03a013

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 131.0a1 (2024-08-30) on Ubuntu 24.04 by following the STR from Comment 0.

The issue is fixed on Firefox 132.0a1 (2024-09-04). Tests were performed on Windows 11 and Ubuntu 24.04.