Closed Bug 1915886 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 47889 - [EncodedTransform] Add WPT for owner of the frames

Categories

(Core :: WebRTC: Networking, task, P4)

Product:
Core
Component:
WebRTC: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47889 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47889
Details from upstream follow.

Lucia <alonsomozol@google.com> wrote:

[EncodedTransform] Add WPT for owner of the frames

Implement a WPT to test the logic ensuring that only frames previously read by the same owner can be written.

Additionally, moved function appendToBuffer to a helper.

Bug: 354881878

Change-Id: I5db43b3e1dac1c0f243c0a7126b6fc2e5091af50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5827535
Reviewed-by: Guido Urdaneta \<guidou@chromium.org>
Reviewed-by: Palak Agarwal \<agpalak@chromium.org>
Commit-Queue: Lucía Alonso Mozo \<alonsomozol@google.com>
Cr-Commit-Position: refs/heads/main@{#1349215}

Component: web-platform-tests → WebRTC: Networking
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 4 subtests

Status Summary

Firefox

OK : 10[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 11[Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 13[GitHub]
PASS : 81[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] 82[Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 83[Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL : 30[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 34[GitHub]
TIMEOUT: 2
ERROR : 1
NOTRUN : 1

Chrome

OK : 14
PASS : 69
FAIL : 50
ERROR : 1

Safari

OK : 12
PASS : 68
FAIL : 47
TIMEOUT: 4
ERROR : 1
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /webrtc-encoded-transform/RTCRtpScriptTransform-sender-worker-single-frame.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • RTCRtpSender initializes its transform attribute and the Worker sends an RTCEncodedAudioFrame back: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
    • RTCRtpSender initializes its transform attribute and the Worker sends an RTCEncodedVideoFrame back: NOTRUN (Chrome: PASS, Safari: NOTRUN)
  • /webrtc-encoded-transform/script-late-transform.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • video exchange with late receiver transform: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc-encoded-transform/sframe-keys.https.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: ERROR, Safari: ERROR)
    • Passing various key IDs: FAIL (Chrome: FAIL, Safari: FAIL)
    • Audio exchange with SFrame setup: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc-encoded-transform/sframe-transform-in-worker.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • video exchange with SFrame transform in worker: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc-encoded-transform/RTCRtpScriptTransform-encoded-transform.https.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: OK, Safari: TIMEOUT)
    • Receiver and sender read, modifiy and write video frames.: FAIL (Chrome: PASS, Safari: FAIL)
    • Receiver and sender read, modifiy and write audio frames.: FAIL (Chrome: PASS, Safari: FAIL)
    • The sender sends both a video frame it doesn't own and one it does. Receiver only gets the frame owned by the sender.: PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] (Chrome: FAIL, Safari: TIMEOUT)
    • The sender sends both an audio frame it doesn't own and one it does. Receiver only gets the frame owned by the sender.: NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview], PASS [Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: FAIL, Safari: NOTRUN)
  • /webrtc-encoded-transform/idlharness.https.window.html [wpt.fyi]
    • SFrameTransform interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface object name: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface: operation setEncryptionKey(CryptoKey, optional CryptoKeyID): FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransform interface: attribute onerror: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface object name: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: attribute errorType: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: attribute keyID: FAIL (Chrome: FAIL, Safari: FAIL)
    • SFrameTransformErrorEvent interface: attribute frame: FAIL (Chrome: FAIL, Safari: FAIL)
    • RTCEncodedVideoFrame interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • RTCEncodedAudioFrame interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • RTCRtpSender interface: operation generateKeyFrame(optional sequence<DOMString>): FAIL (Chrome: FAIL, Safari: FAIL)
    • RTCRtpSender interface: new RTCPeerConnection().addTransceiver('audio').sender must inherit property "generateKeyFrame(optional sequence<DOMString>)" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
    • RTCRtpSender interface: calling generateKeyFrame(optional sequence<DOMString>) on new RTCPeerConnection().addTransceiver('audio').sender with too few arguments must throw TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc-encoded-transform/script-metadata-transform.https.html [wpt.fyi]
    • audio metadata: contributingSources: FAIL (Chrome: PASS, Safari: PASS)
    • video metadata: frameId: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc-encoded-transform/tentative/RTCEncodedVideoFrame-metadata.https.html [wpt.fyi]
    • [VP8] setMetadata() carries over codec-specific properties: FAIL (Chrome: PASS, Safari: FAIL)
    • [VP8] constructor carries over codec-specific properties: FAIL (Chrome: PASS, Safari: FAIL)
    • [VP8] constructor with metadata carries over codec-specific properties: FAIL (Chrome: PASS, Safari: FAIL)
    • [VP8] constructor without metadata does not carry over modified metadata : FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /webrtc-encoded-transform/RTCRtpScriptTransform-sender-worker-single-frame.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
  • /webrtc-encoded-transform/script-late-transform.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webrtc-encoded-transform/sframe-keys.https.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: ERROR, Safari: ERROR)
  • /webrtc-encoded-transform/sframe-transform-in-worker.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/4b905bb0d053 [wpt PR 47889] - [EncodedTransform] Add WPT for owner of the frames, a=testonly https://hg.mozilla.org/mozilla-central/rev/751baea67916 [wpt PR 47889] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4b905bb0d053
https://hg.mozilla.org/mozilla-central/rev/751baea67916

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.