1915973 - [wpt-sync] Sync PR 47904 - [EncodedTransform] Add WPT for order of writing the frames

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47904 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47904
Details from upstream follow.

Lucia <[e-mail]> wrote:

[EncodedTransform] Add WPT for order of writing the frames

Implement a WPT to test the logic ensuring that frames can only be written if they were previously read in the same order.

Bug: 354881878

Change-Id: Ie2453f5a12b54c26c29f404144859f6b23d92d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823486
Reviewed-by: Palak Agarwal \<[e-mail]>
Reviewed-by: Guido Urdaneta \<[e-mail]>
Commit-Queue: Lucía Alonso Mozo \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1349216}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 47904 applied with additional changes from upstream: 3c27011dfd756d0f77d8efb58b286dfb9c5f214a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6809110f9c3979c8b7ba3d95123f78aceafae061

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS : 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] 4[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug]
FAIL : 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] 4[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug]
TIMEOUT: 2
NOTRUN : 3

Chrome

TIMEOUT: 2
NOTRUN : 7

Safari

OK : 1
PASS : 2
FAIL : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-encoded-transform/RTCRtpScriptTransform-encoded-transform.https.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: OK)
  • Receiver and sender read, modifiy and write video frames.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Receiver and sender read, modifiy and write audio frames.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • The sender sends both a video frame it doesn't own and one it does. Receiver only gets the frame owned by the sender.: PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)
  • The sender sends both an audio frame it doesn't own and one it does. Receiver only gets the frame owned by the sender.: NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug] (Chrome: NOTRUN, Safari: FAIL)
  • Sender writes video frames in incorrect order. Frames written in incorrect order are discarded.: FAIL [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)
  • Sender writes audio frames in incorrect order. Frames written in incorrect order are discarded.: FAIL [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: NOTRUN, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/0c04b87cdf08
[wpt PR 47904] - [EncodedTransform] Add WPT for order of writing the frames, a=testonly
https://hg.mozilla.org/mozilla-central/rev/b4a0293db9ea
[wpt PR 47904] - Update wpt metadata, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0c04b87cdf08
https://hg.mozilla.org/mozilla-central/rev/b4a0293db9ea