1915988 - Fail fast in ContentProcess::Init()

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Andrew McCreight [:mccr8]]

If ContentProcess::Init() fails, then we destroy ContentChild and crash. If we crash immediately, then we'll get more specific information about what might be going wrong. The goal is to get more information about what is going wrong in bug 1915788. There's decent volume of that crash on Nightly.

This does not help with NS_InitXPCOM which is its own pile of checks that can fail, but knowing that is failing would at least help a little.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1915988, part 1 - Make ContentProcess::Init crash instead of failing.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1915988, part 2 - Make non-main process NS_InitXPCOM infallible.

Comment 3

[Andrew McCreight [:mccr8]]

Android try push: https://treeherder.mozilla.org/jobs?repo=try&revision=6361bae1dbf140ed82ef57db0b20ab984c7bff43

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b604929fbaee
part 1 - Make ContentProcess::Init crash instead of failing. r=nika
https://hg.mozilla.org/integration/autoland/rev/107cb232c4f7
part 2 - Make non-main process NS_InitXPCOM infallible. r=nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/4f7a933d8072
part 1 - Make ContentProcess::Init crash instead of failing. r=nika
https://hg.mozilla.org/mozilla-central/rev/21525ab3e367
part 2 - Make non-main process NS_InitXPCOM infallible. r=nika

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4f7a933d8072
https://hg.mozilla.org/mozilla-central/rev/21525ab3e367

Comment 7

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/b604929fbaee
https://hg.mozilla.org/mozilla-central/rev/107cb232c4f7