1916026 - Minor improvement to WritingModes.h

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1916026 Part 1 - Improve the readability of WritingMode::PhysicalAxis(). r?#layout

Rewrite PhysicalAxis() to avoid bit manipulation and remove the dependency on
the numeric values of PhysicalAxis and LogicalAxis enums.

This doesn't change behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1916026 Part 2 - Revise outdated comments in WritingModes.h. r?#layout

Many classes contain a WritingMode member variable that may not be initialized
immediately upon construction but rather during later computations. Therefore,
having a default constructor providing a default writing mode remains necessary.

WritingMode::SetDirectionFromBidiLevel()'s input argument was changed from
uint8_t to a helper class in
https://hg.mozilla.org/mozilla-central/rev/20965e0af9b3f8cc2689be5ba6ae323cb9af4436

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e0ae8f9812
Part 1 - Improve the readability of WritingMode::PhysicalAxis(). r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/2ffd311ab17c
Part 2 - Revise outdated comments in WritingModes.h. r=layout-reviewers,jfkthame

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bustage on WritingModes.h

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fbeccad4edc
Part 1 - Improve the readability of WritingMode::PhysicalAxis(). r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/fb64cdaf7a5c
Part 2 - Revise outdated comments in WritingModes.h. r=layout-reviewers,jfkthame

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7fbeccad4edc
https://hg.mozilla.org/mozilla-central/rev/fb64cdaf7a5c