1916028 - touchscreen pinch zooming doesn't work on Google Earth

Status: ASSIGNED

(Core :: Panning and Zooming, defect, P2)

Description

[Will]

Go to Google Earth and pinch zoom via the touchscreen. Observe that Google Earth goes black and glitches. Interestingly, pinch zooming via the touchpad works fine.

Pinch zooming via touchscreen in Chrome works fine too.

Device is a Surface Laptop, Windows 11.

Note: I have left feedback in Google Earth reporting the issue but it might not be on their end. And even if it is, fixing this for Firefox users probably isn't a priority for them.

Comment 1

[Will]

Sorry I should have specified: pinch zooming OUT works ok (though still some weird issues), it's pinch zooming in where I immediately see the problems

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Sotaro Ikeda [:sotaro]]

:botond, can you comment to this bug?

Comment 4

[Botond Ballo [:botond]]

I can reproduce this on a Thinkpad touchscreen.

Google Earth is a site that clearly intends to preventDefault() every pinch gesture (such that the page, not the browser, handles the gesture). The symptoms suggest that some gestures (or parts of gestures) are not getting successfully preventDefault()ed, and we get the browser's default handling of the pinch gesture instead of (or in addition to) the page's.

It's not clear whether this is a site or browser issue; adding [apz-needsdiagnosis] tag for further investigation.

Comment 5

[Botond Ballo [:botond]]

See also bug 1866028 for a bug with similar symptoms which does have a diagnosis (in bug 1866028 comment 3). It's possible that this is the same issue (but this needs to be confirmed).

Comment 6

[Botond Ballo [:botond]]

This is also reproducible in Firefox for Android if you load the site in desktop mode (the mobile site just redirects to the Play Store page for the Google Earth app).

Comment 7

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)

See also bug 1866028 for a bug with similar symptoms which does have a diagnosis (in bug 1866028 comment 3). It's possible that this is the same issue (but this needs to be confirmed).

Note that unlike this bug, bug 1866028 is about touchpad scrolling.

For touchscreen scrolling (like this bug), web authors have ways to disable the browser default behaviour with 100% reliability (namely, touch-action: none) that they don't (yet) have for touchpad scrolling.

Comment 8

[Will]

Just thought it might be helpful to note that Google Maps works fine in Firefox, both touchscreen and touchpad, as well as when you go into Street View too. I'm a bit surprised by this because I thought Google Maps and Google Earth are built on the same tech?

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: A reduced test case

I managed to create a reduced test case. It's related to shadow DOM that I am not familiar with.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Attachment: A minimized test case

It turned out that shadow DOM is unrelated. It's caused by nested pointer-events styles.

The problem lies on here in [nsIFrame::GetCompositorHitTestInfo] returning an empty hit-info, and here in UpdateCurrentHitTestInfo to replace nsDisplayListBuilder::mCompositorHitTestInfo with the empty one.

I am pretty sure this was regressed by bug 1534549.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1534549

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1916028 - Do not propagate ancestor's pointer-events property in nsDisplayBuilder::mCompositorHitTestInfo. r?tnikkel,mstange

Rather check pointer-events proeprty in nsIFrame::GetCompositorHitTestInfo
because pointer-events property is inherited but pointer-events: auto cancels
out the inherited pointer-events: none.

Comment 13

[Daniel Holbert [:dholbert]]

Let's consider 'fix-optional' for 133 (which is about to merge to beta). (Though perhaps it's really wontfix for that release, unless it feels like an extremely safe fix.)