1916071 - WebGPU: Electronic Arts' PB-MPM page fails to run

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

Saw this page floating around in the WebGPU community in Matrix, and wanted to make sure it worked in Firefox, too.

Source: https://github.com/electronicarts/pbmpm

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Shaders from this page appear to fail because of the following dependencies (first by dep., then by shader name):

• Automatic type conversion (bug 1829879):
  • bukkitAllocate
  • bukkitCount
  • g2p2g
  • particleEmit
  • setIndirectArgs
• Indexing by-value arrays using dynamic values (bug 1913424):
  • particleRender

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

There are actually several samples offered on this page, but not even the first one loads because of issues in comment 1. Once unblocked, we should check that all samples work.

Comment 3

[Andy Leiserson [:aleiserson]]

Currently, I see type conversion issues with atomicAdd and select.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Even though https://github.com/gfx-rs/wgpu/issues/6443 is resolved, this still has the atomicAdd and select issues that Andy pointed out.

e.g.:

Shader validation error: Function [19] 'collide' is invalid
    ┌─ g2p2g:317:1
    │  
317 │ ╭ fn collide(shape: SimShape, pos: vec2f) -> CollideResult
318 │ │ {
319 │ │     if(shape.shapeType == ShapeTypeCircle)
320 │ │     {
    · │
323 │ │         let normal = offset * select(1.0/offsetLen, 0, offsetLen == 0);
    │ │                               ^^^^^^ naga::ir::Expression [13]
    · │
352 │ │     {
353 │ │         return CollideResult(false, 0.0, vec2f(0,0), vec2f(0,0));
    │ ╰─────────────────────────────────────────────────────────────────^ naga::ir::Function [19]
    │  
    = Expression [13] is invalid
    = Expected selection argument types to match, but reject value of type Scalar(Scalar { kind: Float, width: 4 }) does not match accept value of value Scalar(Scalar { kind: Sint, width: 4 })

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

atomicAdd is bug 1960093, select is bug 1960453.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

I can confirm that atomicAdd shader compilation errors are no longer coming up. 😤Now we're just awaiting the resolution to bug 1960453.

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

WFM now, with dependencies satisfied! Woot!

...except I noticed a crash I get occasionally that doesn't seem specific to this page; filed bug 1973591 to follow up with this.