1916086 - Debugger crash when debugging userscript code

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Roman Deev]

Error:
RangeError: Mark decorations may not be empty

React Component Stack:
in InlinePreviews
in Connect(InlinePreviews)
in div
in Editor
in Connect(Editor)
in div
in main
in div
in div
in SplitBox
in div
in div
in SplitBox
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in Provider

Stacktrace:
range@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:72355
_buildDecorationsForPositionMarkers@resource://devtools/client/shared/sourceeditor/editor.js:1249:31
updateDecorationsForAllMarkers@resource://devtools/client/shared/sourceeditor/editor.js:1295:44
update@resource://devtools/client/shared/sourceeditor/editor.js:1346:33
update@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:22755
applyTransaction/<@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:31323
tt@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:25475
kt@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:30513
applyTransaction@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:31291
get state@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:26945
update@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:169562
Bs/this.dispatchTransactions<@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:168450
dispatch@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:169233
removeLineContentMarker@resource://devtools/client/shared/sourceeditor/editor.js:1120:8
componentWillUnmount@resource://devtools/client/debugger/src/components/Editor/InlinePreviews.js:111:23
callComponentWillUnmountWithTimer@resource://devtools/client/shared/vendor/react-dom.js:12816:12
safelyCallComponentWillUnmount@resource://devtools/client/shared/vendor/react-dom.js:12824:40
commitUnmount@resource://devtools/client/shared/vendor/react-dom.js:13147:41
commitNestedUnmounts@resource://devtools/client/shared/vendor/react-dom.js:13178:18
unmountHostComponents@resource://devtools/client/shared/vendor/react-dom.js:13439:27
commitDeletion@resource://devtools/client/shared/vendor/react-dom.js:13498:26
commitAllHostEffects@resource://devtools/client/shared/vendor/react-dom.js:14142:25
commitRoot@resource://devtools/client/shared/vendor/react-dom.js:14344:9
completeRoot/<@resource://devtools/client/shared/vendor/react-dom.js:15731:15
unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12
completeRoot@resource://devtools/client/shared/vendor/react-dom.js:15730:27
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15659:21
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
promiseMiddleware/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:57:15

Comment 1

[Roman Deev]

How to reproduce a crash:

1. Install Violentmonkey https://addons.mozilla.org/firefox/addon/violentmonkey
2. Install the userscript https://gist.github.com/deevroman/edf70a71bbcd168274e5bcb515b717bf/raw/162bd9bc288ff39209a567b66ab0768bc5c97d40/crash.user.js
3. Open https://www.openstreetmap.org
4. Open a debugger
5. Reload the page.
6. Crash

Comment 2

[Roman Deev]

Attachment: Запись экрана 2024-09-01 в 09.01.39 2.mov

Comment 3

[Roman Deev]

devtools.debugger.features.codemirror-next=true

Comment 4

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

Thanks for reporting Roman.
i can reproduce the issue, looking to fix.

Comment 5

[Hubert Boma Manilla (:bomsy) PTO until Jan 6th]

Attachment: Bug 1916086 - [devtools] Valid tokens should always start at the position specified r=#devtools-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec7d761229b
[devtools] Valid tokens should always start at the position specified r=devtools-reviewers,nchevobbe

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3ec7d761229b