1916131 - Run `PRAGMA optimize` when closing an Skv database connection

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task)

Description

[Lina Butler (ex-Mozilla)]

Marco suggested doing this in bug 1913241, comment 1, and we have a few examples of PRAGMA optimize(0x02) in the tree.

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1916131 - Refactor `ConnectionOpener` into `ConnectionMigrator`. r?nanj!

Pragmas, configuration options, and functions aren't schema-specific,
so having them in the skv::Schema type felt a bit confusing.

This commit:

• Inlines and splits the logic from Schema::setup() into
  Connection::new() and skv::functions::register().
• Renames ConnectionOpener to ConnectionMigrator, since the trait
  only handles migrations now.

Comment 2

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1916131 - Run `PRAGMA optimize` for Skv connections. r?nanj!

Depends on D224570

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a41cad75786c
Refactor `ConnectionOpener` into `ConnectionMigrator`. r=nanj
https://hg.mozilla.org/integration/autoland/rev/37a00e3f23e5
Run `PRAGMA optimize` for Skv connections. r=nanj

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a41cad75786c
https://hg.mozilla.org/mozilla-central/rev/37a00e3f23e5