1916195 - Revamped sidebar separation is significantly wider and has additional borders on Linux

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P3)

Description

[Kestrel]

Attachment: Comparison showing larger sidebar separation on Ubuntu

STR:

1. Start with sidebar.revamp = true on Ubuntu 24.04.
2. Open the History sidebar (Ctrl+H).

Expected:
The sidebar separation width is similar to Windows (8px).

Actual:
The sidebar separation width is 16px and has additional borders from the splitter itself.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=936f3047272d1ef5feb4f02953db3ad74c59bbd1&tochange=95109305b579922c59ef5966e60c9397e48847ac

Regressed by Bug 1910733.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:nsharpley, since you are the author of the regressor, bug 1910733, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910733

Comment 3

[Sarah Clements [:sclements]]

Kestrel, please stop adding the regression keyword to bugs you file; its a distraction having this tracked and commented on by the bug bot. This work is only in Nightly now and we are not rolling it out to release in 132.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1916195 - Unify sidebar splitter across platforms. r=#sidebar-reviewers

Comment 5

[Gregory Pappas [:gregp]]

The regression keyword is automatically added by bugzilla when the Regressed by field is populated (bug 1811647)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64674255040c
Unify sidebar splitter across platforms. r=sidebar-reviewers,desktop-theme-reviewers,emilio,kcochrane

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/64674255040c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 132.0a1 (2024-09-03) on Ubuntu 24.04. The sidebar separation is significantly wider than on 132.0b2.
The issue is verified fixed with Firefox 132.0b2 on Ubuntu 24.04. The sidebar separation looks similar on Ubuntu 24.04, Windows 10x64, and macOS 12.