1916286 - resource://devtools/shared/loader/builtin-modules.js fails to open on Windows local build

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

This started to happen after mozweek, the clobber build doesn't help and the whole devtools is broken. 😞

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

cc bobowen in case this is sandbox related.

Log when opening devtools:

console.error: "Failed to sendQuery in DevToolsProcessParent" "DevToolsProcessParent:watchTargets"
console.error: "Error: Module `resource://devtools/shared/loader/builtin-modules.js` is not found at resource://devtools/shared/loader/builtin-modules.js"
console.error: "Error while calling actor 'watcher's method 'watchTargets'" "Module `resource://devtools/shared/loader/builtin-modules.js` is not found at resource://devtools/shared/loader/builtin-modules.js"
console.error: (new Error("Module `resource://devtools/shared/loader/builtin-modules.js` is not found at resource://devtools/shared/loader/builtin-modules.js", "resource://devtools/shared/loader/base-loader.sys.mjs", 193))
console.error: "Exception while opening the toolbox" "Error: Protocol error (Error): Module `resource://devtools/shared/loader/builtin-modules.js` is not found at resource://devtools/shared/loader/builtin-modules.js from: server0.conn0.watcher2 (resource://devtools/shared/loader/base-loader.sys.mjs:193:15)" (new Error("Protocol error (Error): Module `resource://devtools/shared/loader/builtin-modules.js` is not found at resource://devtools/shared/loader/builtin-modules.js from: server0.conn0.watcher2 (resource://devtools/shared/loader/base-loader.sys.mjs:193:15)", "resource://devtools/shared/protocol/Front.js", 382))
onPacket/<@resource://devtools/shared/protocol/Front.js:382:31
DevTools RDP*request@resource://devtools/shared/protocol/Front.js:299:14
generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
startListening@resource://devtools/shared/commands/target/target-command.js:478:35
open/<@resource://devtools/client/framework/toolbox.js:956:41
open@resource://devtools/client/framework/toolbox.js:1143:18
_createToolbox@resource://devtools/client/framework/devtools.js:750:19

JavaScript error: resource://devtools/client/framework/toolbox.js, line 4235: TypeError: can't access property "forEach", this.toolbarButtons is undefined

Comment 2

[Alexandre Poirot [:ochameau]]

The exception originates from here and seems to be about not being able to load resource://devtools/shared/loader/builtin-modules.js from a content process.

I'm running DevTools fine from today's Nightly on Windows 11.
Is there some particular sandbox pref/settings different between local build and nightly?

krosylight, is the failure only happening with local build and it works fine on Nightly?

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

nightly is fine. The local build uses symlink to obj directory so that one doesn't have to rebuild every time when a JS file is changed, and for sandbox that matters.

Comment 4

[:Gijs (away/busy until Mar 10)]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #3)

The local build uses symlink to obj directory so that one doesn't have to rebuild every time when a JS file is changed, and for sandbox that matters.

I don't think this is true for a regular Windows local build, as symlinks are not supported. What kind of environment are you using to build your Windows local build?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Symlinks on Windows have been supported since 2020: bug 1634454, bug 1635428.

Comment 6

[Bob Owen (:bobowen)]

It looks like we are blocking another resource with the new USER_RESTRICTED access token level that we are testing in Nightly.
The builtin-modules.js file itself is being brokered as normal, but there is another resource MountPointManager that is blocked afterwards.

Comment 7

[Bob Owen (:bobowen)]

Adding read access to \??\MountPointManager seems to fix the problem.
Patch up soon.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Thank you Bob!

Comment 9

[Bob Owen (:bobowen)]

Attachment: Bug 1916286: Add rule for MountPointManager in AddDeveloperRepoDirToPolicy. r=yjuglaret!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ab7d0c41acd
Add rule for MountPointManager in AddDeveloperRepoDirToPolicy. r=yjuglaret

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5ab7d0c41acd