1916333 - Filter input icons keep their original color in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Filter input clear button in High Contrast Mode

Note that by default there's an 0.8 opacity applied to the button, which is only re-set to 1 when the button is hovered/focused. Not sure if this should still be done in HCM

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Filter icon with modified color, in High Contrast Mode

Note that it also impacts the filter icon at the start of the input

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Note that the filter icon at the beginning of the input is also impacted

Comment 3

[Morgan Reschenberg [:morgan]]

Triaging S2 because, as I understand it, this UI doesn't adapt to HCM. Please re-triage to S3 if it is adapting but in incorrect colours for its role.
We should always have opacity = 100% in HCM

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nchevobbe, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

We usually don't align a11y severity and severity in DevTools, but we'll set a P2 for all a11y s2 as we plan to work on this in the next months

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916333 - [devtools] Adapt Console filter input clear button in High Contrast Mode. r=#devtools-reviewers,#accessibility-frontend-reviewers

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916333 - [devtools] Adapt Console filter input icon color in High Contrast Mode. r=#devtools-reviewers,#accessibility-frontend-reviewers

Comment 8

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916333 - [devtools] Adapt console filter input colors in High Contrast Mode. r=#devtools-reviewers,#accessibility-frontend-reviewers.

This adds proper border and outline colors to the console filter input.
The filter height is reduced so those are visible, and we also
hide the separator around it which are not needed in HCM since we
display the border on the input.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/283ea385b220
[devtools] Adapt Console filter input clear button in High Contrast Mode. r=devtools-reviewers,accessibility-frontend-reviewers,nlapre,ochameau
https://hg.mozilla.org/integration/autoland/rev/9cb905f3f50a
[devtools] Adapt Console filter input icon color in High Contrast Mode. r=devtools-reviewers,accessibility-frontend-reviewers,nlapre,ochameau
https://hg.mozilla.org/integration/autoland/rev/76364a160d4d
[devtools] Adapt console filter input colors in High Contrast Mode. r=devtools-reviewers,accessibility-frontend-reviewers,nlapre,ochameau.

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/283ea385b220
https://hg.mozilla.org/mozilla-central/rev/9cb905f3f50a
https://hg.mozilla.org/mozilla-central/rev/76364a160d4d