1916335 - Active tab in toolbox toolbar only differs from inactive tab by its icon color in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Toolbox toolbar with console tab selected

When a tab is selected, in High Contrast mode the only thing that distinguish it from the others, inactive tabs is the icon color (which is the non-forced icon color): we're losing the top border and the color of the text.
I guess we should make sure that the border is visible, and use a system color for the icon

Comment 1

[Morgan Reschenberg [:morgan]]

Triaging as S2 because, although indication is given, the colour used is not from the HCM palette (I think it's using Firefox blue)

Comment 2

[BugBot [:suhaib / :marco]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:Honza, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Higher a11y severity is correct in this case.

Comment 4

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 5

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 1916335 - [devtools] Adapt toolbox tool tabs to High Contrast Mode. r=#devtools.

In High Contrast Mode, we do set borders on tabs, which revealed the need for
space between the different tabs.
We also hide the separator we have between the node picker and the tabs to avoid
making the tab tray too busy.
When a tab is selected, we set its whole background with a specific color, and
we hide the small active line we have in regular mode.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4151f3658bc9
[devtools] Adapt toolbox tool tabs to High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4151f3658bc9