1916341 - Pretty print icon in Editor toolbar is not visible in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Focused pretty print icon in toolbar, icon is missing

See screenshot (the button is focused so it has an outline, but the icon is completely missing)

Comment 1

[Morgan Reschenberg [:morgan]]

Triaging as S2 because UI doesn't appear in HCM.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nchevobbe, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

We usually don't align a11y severity and severity in DevTools, but we'll set a P2 for all a11y s2 as we plan to work on this in the next months

Comment 4

[Anna Yeddi [:ayeddi]]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916341 - [devtools] Make Console Editor pretty print icon visible in High Contrast Mode. r=#devtools-reviewers.

The button was still using mask-image to properly style the icon, but the svg
does have a context-fill property, so we can use fill directly, which is what
the debugger and style editor are already doing.

With that fixed, it seems reasonable define a specific color for --theme-icon-color
in High Contrast Mode, as it does fix the original bug issue, and will probably
cover a lot of the other issues regarding icon colors in High Contrast Mode.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/389c090df49e
[devtools] Make Console Editor pretty print icon visible in High Contrast Mode. r=devtools-reviewers,ochameau,accessibility-frontend-reviewers,nlapre.

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/389c090df49e