1916351 - JSON mime type should only be allowed for JS module loads

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Tom S. (please needinfo tschuster)]

https://hg.mozilla.org/integration/autoland/rev/1de3f8d89dec seems to allow the JSON MIME type for all JavaScript loads, but I think JSON should only be allowed for JS module loads.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jon4t4n, since you are the author of the regressor, bug 1877792, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1916351 - Only allow JSON mime type for javascript modules r=evilpie!,#necko-reviewers!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877792

Comment 4

[Jonatan Klemets [:jon4t4n]]

Oh, good catch. I think you are correct. Added a WIP patch that I think solves this issue.

(I'll try to write a test case while waiting for the try run.)

Try push for with the WIP patch: https://treeherder.mozilla.org/jobs?repo=try&revision=2872c7d6a2b1635d5258d9343106bf8ae0067895

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920579be1c72
Only allow JSON mime type for javascript modules r=evilpie,necko-reviewers,devtools-reviewers,jesup,nchevobbe

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/920579be1c72