Closed Bug 1916352 Opened 1 year ago Closed 1 year ago

Increasing idle timeout for TRR connection

Tracking

()

Status:

RESOLVED FIXED

Milestone:

132 Branch

Tracking Flags:

Tracking

Status

firefox132

---

fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1916352 - Increase network.http.largeKeepaliveFactor and record DNS_TRR_REQUEST_PER_CONN on release, r=#necko 1 year ago Kershaw Chang [:kershaw] 48 bytes, text/x-phabricator-request		Details \| Review

Kershaw Chang [:kershaw]

Assignee

Description

•

1 year ago

The current idle timeout for TRR connections is 1700 seconds, which might be too short. The probe DNS_TRR_REQUEST_PER_CONN shows that at the 50th percentile, a connection processes only 1-2 DoH requests. Increasing the idle timeout could improve the utilization of TRR connections.

Kershaw Chang [:kershaw]

Assignee

Comment 1

•

1 year ago

Attached file Bug 1916352 - Increase network.http.largeKeepaliveFactor and record DNS_TRR_REQUEST_PER_CONN on release, r=#necko — Details

Pulsebot

Comment 2

•

1 year ago

Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12a8641c8e79 Increase network.http.largeKeepaliveFactor and record DNS_TRR_REQUEST_PER_CONN on release, r=necko-reviewers,valentin,edgul

Iulian Moraru

Comment 3

•

1 year ago

Backed out for causing gv-junit failures related to LargeKeepaliveFactor.

[task 2024-09-04T09:34:53.446Z] 09:34:53     INFO -  TEST-START | org.mozilla.geckoview.test.RuntimeSettingsTest#largeKeepaliveFactor
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1162
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | Error in largeKeepaliveFactor(org.mozilla.geckoview.test.RuntimeSettingsTest):
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | java.lang.AssertionError: default LargeKeepaliveFactor should be 10
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | Expected: is <10>
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test |      but: was <20>
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2024-09-04T09:34:53.641Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.Assert.assertThat(Assert.java:964)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:77)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:90)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:75)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:927)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:168)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.RuntimeSettingsTest.largeKeepaliveFactor(RuntimeSettingsTest.kt:228)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test |
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=largeKeepaliveFactor
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.RuntimeSettingsTest
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stack=java.lang.AssertionError: default LargeKeepaliveFactor should be 10
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | Expected: is <10>
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test |      but: was <20>
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.Assert.assertThat(Assert.java:964)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:77)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:90)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:75)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:927)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:168)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.RuntimeSettingsTest.largeKeepaliveFactor(RuntimeSettingsTest.kt:228)
[task 2024-09-04T09:34:53.643Z] 09:34:53     INFO -  org.mozilla.geckoview.test |
[task 2024-09-04T09:34:53.644Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=656
[task 2024-09-04T09:34:53.644Z] 09:34:53     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: -2
<...>
[task 2024-09-04T09:34:54.131Z] 09:34:54     INFO -  09-04 09:34:52.875 E/GeckoRuntimeSettings( 3456): largeKeepaliveFactor must be between 1 to 10 inclusive
[task 2024-09-04T09:34:54.132Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): Error
[task 2024-09-04T09:34:54.132Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): java.lang.AssertionError: default LargeKeepaliveFactor should be 10
[task 2024-09-04T09:34:54.132Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): Expected: is <10>
[task 2024-09-04T09:34:54.132Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456):      but: was <20>
[task 2024-09-04T09:34:54.132Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.Assert.assertThat(Assert.java:964)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:77)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:90)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:75)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:927)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:168)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.RuntimeSettingsTest.largeKeepaliveFactor(RuntimeSettingsTest.kt:228)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0(GeckoSessionTestRule.java:1502)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.$r8$lambda$iCBopfpsbLU-HFWW53O-4m1PB6c(GeckoSessionTestRule.java)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at android.os.Looper.loop(Looper.java:154)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.884 E/GeckoSessionTestRule( 3456): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  09-04 09:34:52.890 E/GeckoSessionTestRule( 3456): test_end c5ee677f-bc83-49bd-9e28-2d35f3d0f059 largeKeepaliveFactor(org.mozilla.geckoview.test.RuntimeSettingsTest)
[task 2024-09-04T09:34:54.139Z] 09:34:54  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.RuntimeSettingsTest#largeKeepaliveFactor | java.lang.AssertionError: default LargeKeepaliveFactor should be 10
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  TEST-INFO took 683ms
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1162
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=userCharacteristicPingCurrentVersion
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.RuntimeSettingsTest
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=657
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1
[task 2024-09-04T09:34:54.139Z] 09:34:54     INFO -  TEST-START | org.mozilla.geckoview.test.RuntimeSettingsTest#userCharacteristicPingCurrentVersion

Flags: needinfo?(kershaw)

Kershaw Chang [:kershaw]

Assignee

Updated

•

1 year ago

Flags: needinfo?(kershaw)

Pulsebot

Comment 4

•

1 year ago

Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e44a0c0c798d Increase network.http.largeKeepaliveFactor and record DNS_TRR_REQUEST_PER_CONN on release, r=necko-reviewers,valentin,edgul

pstanciu

Comment 5

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e44a0c0c798d

Status: NEW → RESOLVED

Closed: 1 year ago

status-firefox132: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 132 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Increasing idle timeout for TRR connection

Categories

(Core :: Networking: DNS, task, P2)

Tracking

()

People

(Reporter: kershaw, Assigned: kershaw)

References

Details

(Whiteboard: [necko-triaged])

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Updated

Comment 4

Comment 5

Attachment

General

Description

File Name

Content Type