1916418 - Don't use HTTPS record if the target name is not the same as CNAME of address record

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1916418 - Ignore the svcb record when the targetName doesn't match cname, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1916418 - Enable network.dns.echconfig.fallback_to_origin_when_all_failed, r=#necko,djackson

When DoH is disabled, the native DNS resolver can't provide CNAME information.
This means that when the native HTTPS resolver is enabled, we might still use an HTTPS record with a mismatched TargetName and CNAME.
To ensure a smooth browsing experience for users, it's unfortunate that we need to enable this preference.

Depends on D222145

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1916418 - Expose IsTRR for nsIDNSHTTPSSVCRecord, r=#necko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dffe7e257106
Ignore the svcb record when the targetName doesn't match cname, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/3ce20d01a9ac
Expose IsTRR for nsIDNSHTTPSSVCRecord, r=necko-reviewers,valentin

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - build bustages
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/netwerk/protocol/http/HTTPSRecordResolver.cpp(40,42): error: no member named 'components' in namespace 'mozilla'

---

• Push with failures - xpcshell failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr_https_rr_with_cname.js | xpcshell return code: 0

Comment 6

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/jobs?repo=try&revision=66619303757f7b1b2009d627c3234a2e81003c6f

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dee53e26cb1b
Ignore the svcb record when the targetName doesn't match cname, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/7a4bfea4ab31
Expose IsTRR for nsIDNSHTTPSSVCRecord, r=necko-reviewers,valentin

Comment 8

[Atila Butkovits]

Backed out for causing failures at test_trr_https_rr_with_cname.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/706662d8fbaf26ebcb0c445e2376e57af8830a56

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7a4bfea4ab31ce7039e0b29c3a08dc198a19b9e6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477049666&repo=autoland&lineNumber=4026

Comment 9

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3db90fe3ba12ec4c712d8af6115bdfbc49e24b6a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c523b497ed7
Ignore the svcb record when the targetName doesn't match cname, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/9ed70a6fbf2a
Expose IsTRR for nsIDNSHTTPSSVCRecord, r=necko-reviewers,valentin

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0c523b497ed7
https://hg.mozilla.org/mozilla-central/rev/9ed70a6fbf2a

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0c523b497ed7
https://hg.mozilla.org/mozilla-central/rev/9ed70a6fbf2a