1916505 - Add support for a search form URL to the search configuration

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1907034, we have re-added the option to open the search engine page without a search. The patch there uses the prePath of the search URL. For the majority of engines this works fine, however for some engines we need to additionally specify the path or parameters. We therefore need to make it possible in the search configuration to supply these.

To do this we should:

• Update the search configuration schema to include a new URL option (form?).
• Update the engine selector & search service code to be able to use the URL when specified.
• If it is not specified, it should fallback to the prePath, like it does now.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1916505 - Add support for a search form URL to the search configuration. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbd2ce7823c2
Add support for a search form URL to the search configuration. r=Standard8

Comment 3

[amarc]

Backed out for causing bc failures @ browser_oneOffContextMenu.js

• Backout link
• Push with failures
• Failure Log
• Failure snippet:

[task 2024-10-31T13:35:30.017Z] 13:35:30     INFO - TEST-PASS | browser/components/search/test/browser/browser_oneOffContextMenu.js | One-off for Foo should exist - "[object XULElement]" != "undefined" - 
[task 2024-10-31T13:35:30.017Z] 13:35:30     INFO - Closing search panel
[task 2024-10-31T13:35:30.017Z] 13:35:30     INFO - TEST-PASS | browser/components/search/test/browser/browser_oneOffContextMenu.js | Expected search tab should have loaded - "http://mochi.test:8888/browser/browser/components/search/test/browser/?search&test=abc" == "http://mochi.test:8888/browser/browser/components/search/test/browser/?search&test=abc" - 
[task 2024-10-31T13:35:30.017Z] 13:35:30     INFO - Leaving test bound testNewtabEmpty
[task 2024-10-31T13:35:30.019Z] 13:35:30     INFO - Entering test bound testNewtabNonempty
[task 2024-10-31T13:35:30.020Z] 13:35:30     INFO - Opening search panel
[task 2024-10-31T13:35:30.020Z] 13:35:30     INFO - TEST-PASS | browser/components/search/test/browser/browser_oneOffContextMenu.js | One-off for Foo should exist - "[object XULElement]" != "undefined" - 
[task 2024-10-31T13:35:30.020Z] 13:35:30     INFO - Closing search panel
[task 2024-10-31T13:35:30.021Z] 13:35:30     INFO - Buffered messages finished
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_oneOffContextMenu.js | Search form should have loaded in new tab - "http://mochi.test:8888/browser/browser/components/search/test/browser/" == "http://mochi.test:8888/" - 
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - Stack trace:
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochitests/content/browser/browser/components/search/test/browser/browser_oneOffContextMenu.js:testNewtabNonempty:73
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2024-10-31T13:35:30.022Z] 13:35:30     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-10-31T13:35:30.023Z] 13:35:30     INFO - Leaving test bound testNewtabNonempty
[task 2024-10-31T13:35:30.023Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7f46269da800) [pid = 12606] [serial = 50] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.024Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f46269dbc00) [pid = 12606] [serial = 49] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.024Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7f46269da000) [pid = 12606] [serial = 47] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.025Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f46269de400 == 1 [pid = 12606] [id = 19] [url = about:blank]
[task 2024-10-31T13:35:30.026Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f46269dcc00 == 0 [pid = 12606] [id = 20] [url = about:blank]
[task 2024-10-31T13:35:30.027Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7ff8fb38b400 == 8 [pid = 12442] [id = 10] [url = chrome://browser/content/browser.xhtml]
[task 2024-10-31T13:35:30.028Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7ff8f522fc00 == 7 [pid = 12442] [id = 14] [url = chrome://browser/content/browser.xhtml]
[task 2024-10-31T13:35:30.028Z] 13:35:30     INFO - GECKO(12442) | [Child 12548: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7f4627c94400) [pid = 12548] [serial = 29] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.028Z] 13:35:30     INFO - GECKO(12442) | [Child 12548: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7f4627c92000) [pid = 12548] [serial = 23] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.029Z] 13:35:30     INFO - GECKO(12442) | [Child 12548: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7f4627c91600) [pid = 12548] [serial = 27] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.029Z] 13:35:30     INFO - GECKO(12442) | [Child 12548: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7f4627c94000) [pid = 12548] [serial = 25] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.030Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7f46269c0c00) [pid = 12606] [serial = 51] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.031Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f46269bfe00) [pid = 12606] [serial = 53] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.031Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, IPC I/O Parent] WARNING: [1.1]: GetUserData call for port '36994BDDDF70FEF1.8C9978451F2C5BE9' failed: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:424
[task 2024-10-31T13:35:30.032Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp:1687
[task 2024-10-31T13:35:30.034Z] 13:35:30     INFO - GECKO(12442) | [Child 13721: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f462876fc00 == 0 [pid = 13721] [id = 0] [url = http://mochi.test:8888/browser/browser/components/search/test/browser/]
[task 2024-10-31T13:35:30.034Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.035Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.037Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.037Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.038Z] 13:35:30     INFO - GECKO(12442) | [Child 13721: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f4628773400) [pid = 13721] [serial = 3] [outer = 0] [url = http://mochi.test:8888/browser/browser/components/search/test/browser/]
[task 2024-10-31T13:35:30.038Z] 13:35:30     INFO - GECKO(12442) | [Child 13721: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f4628769400) [pid = 13721] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.039Z] 13:35:30     INFO - GECKO(12442) | [Child 13721: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f4627e4f400) [pid = 13721] [serial = 1] [outer = 0] [url = http://mochi.test:8888/browser/browser/components/search/test/browser/]
[task 2024-10-31T13:35:30.039Z] 13:35:30     INFO - GECKO(12442) | [Child 12660: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7f4622059000) [pid = 12660] [serial = 98] [outer = 0] [url = about:newtab]
[task 2024-10-31T13:35:30.040Z] 13:35:30     INFO - GECKO(12442) | [Child 12660: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f4622056800) [pid = 12660] [serial = 101] [outer = 0] [url = about:newtab]
[task 2024-10-31T13:35:30.040Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.041Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.041Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.042Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.042Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.043Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.043Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.044Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.055Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.056Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.057Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.058Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.111Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.112Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.121Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.122Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442, sqldb:places.sqlite #2] WARNING: Suboptimal indexes for the SQL statement 0x7ff8fb3dad00 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:114
[task 2024-10-31T13:35:30.206Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7ff8efcc4000 == 6 [pid = 12442] [id = 12] [url = chrome://browser/content/browser.xhtml]
[task 2024-10-31T13:35:30.222Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7ff8f5232c00 == 5 [pid = 12442] [id = 17] [url = about:blank]
[task 2024-10-31T13:35:30.237Z] 13:35:30     INFO - GECKO(12442) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmps55os15g.mozrunner/runtests_leaks_tab_pid13805.log
[task 2024-10-31T13:35:30.249Z] 13:35:30     INFO - GECKO(12442) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmps55os15g.mozrunner/runtests_leaks_tab_pid13812.log
[task 2024-10-31T13:35:30.260Z] 13:35:30     INFO - GECKO(12442) | [Child 13805, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:757
[task 2024-10-31T13:35:30.282Z] 13:35:30     INFO - GECKO(12442) | [Child 13812, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:757
[task 2024-10-31T13:35:30.299Z] 13:35:30     INFO - GECKO(12442) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2024-10-31T13:35:30.300Z] 13:35:30     INFO - GECKO(12442) | [Child 13812, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:467
[task 2024-10-31T13:35:30.936Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 31 (7ff8f681c600) [pid = 12442] [serial = 28] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.936Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 30 (7ff8fa204200) [pid = 12442] [serial = 32] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.937Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 29 (7ff90c5ca200) [pid = 12442] [serial = 20] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.937Z] 13:35:30     INFO - GECKO(12442) | [Parent 12442: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 28 (7ff8fa207e00) [pid = 12442] [serial = 24] [outer = 0] [url = about:blank]
[task 2024-10-31T13:35:30.949Z] 13:35:30     INFO - GECKO(12442) | MEMORY STAT | vsize 11872MB | residentFast 561MB | heapAllocated 301MB
[task 2024-10-31T13:35:30.950Z] 13:35:30     INFO - TEST-OK | browser/components/search/test/browser/browser_oneOffContextMenu.js | took 2247ms
[task 2024-10-31T13:35:30.958Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f46269db000 == 1 [pid = 12606] [id = 21]
[task 2024-10-31T13:35:30.959Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f46269c2a00) [pid = 12606] [serial = 55] [outer = 0]
[task 2024-10-31T13:35:30.959Z] 13:35:30     INFO - GECKO(12442) | [Child 12606: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f46269d9c00) [pid = 12606] [serial = 56] [outer = 7f46269c2a00]
[task 2024-10-31T13:35:30.983Z] 13:35:30     INFO - checking window state
[task 2024-10-31T13:35:31.011Z] 13:35:31     INFO - TEST-START | browser/components/search/test/browser/browser_oneOffContextMenu_setDefault.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b0a991484b8
Add support for a search form URL to the search configuration. r=Standard8

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4b0a991484b8