Remove or update metrics expiring in Firefox 132: networking.set_cookie_expired_without_server_time
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox-esr128 | --- | unaffected |
firefox130 | --- | unaffected |
firefox131 | --- | unaffected |
firefox132 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: edgul)
References
(Regression)
Details
(Keywords: intermittent-failure, regression, Whiteboard: [stockwell needswork:owner])
Attachments
(2 files)
482 bytes,
text/plain
|
cboozarjomehri
:
data-review+
|
Details |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=472754354&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OpqyNtyZQV2np6E_HA-K3A/runs/0/artifacts/public/logs/live_backing.log
[task 2024-09-03T18:59:47.385Z] toolkit/components/glean/tests/pytest/test_jogfile_output.py::test_jogfile_output PASSED
[task 2024-09-03T18:59:47.385Z]
[task 2024-09-03T18:59:47.385Z] ============================== 1 passed in 0.18s ===============================
[task 2024-09-03T18:59:47.385Z]
[task 2024-09-03T18:59:47.385Z]
[task 2024-09-03T18:59:52.670Z] Tests Completed: 86%|████████▌ | 6/7 [00:01<00:00, 3.53Test/s]
[task 2024-09-03T18:59:52.670Z]
[task 2024-09-03T18:59:52.671Z] Setting retcode to 1 from /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_no_expired_metrics.py
[task 2024-09-03T18:59:52.671Z]
[task 2024-09-03T18:59:52.671Z] Tests Completed: 100%|██████████| 7/7 [00:07<00:00, 1.47s/Test]
[task 2024-09-03T18:59:52.671Z]
[task 2024-09-03T18:59:52.671Z] /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_no_expired_metrics.py
[task 2024-09-03T18:59:52.671Z] ============================= test session starts ==============================
[task 2024-09-03T18:59:52.671Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.5.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2024-09-03T18:59:52.671Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2024-09-03T18:59:52.671Z] plugins: mock-3.12.0
[task 2024-09-03T18:59:52.671Z] collecting ... collected 1 item
[task 2024-09-03T18:59:52.671Z]
[task 2024-09-03T18:59:52.671Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py::test_no_metrics_expired TEST-UNEXPECTED-FAIL
[task 2024-09-03T18:59:52.671Z]
[task 2024-09-03T18:59:52.671Z] =================================== FAILURES ===================================
[task 2024-09-03T18:59:52.672Z] ___________________________ test_no_metrics_expired ____________________________
[task 2024-09-03T18:59:52.672Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py:42: in test_no_metrics_expired
[task 2024-09-03T18:59:52.672Z] assert not lint.lint_metrics(all_objs.value, options)
[task 2024-09-03T18:59:52.672Z] E AssertionError: assert not [<glean_parser.lint.GlinterNit object at 0x7f5373fb67f0>]
[task 2024-09-03T18:59:52.673Z] E + where [<glean_parser.lint.GlinterNit object at 0x7f5373fb67f0>] = <function lint_metrics at 0x7f5379d36dc0>({'privacy.sanitize': {'clear': <glean_parser.metrics.Event...
[task 2024-09-03T18:59:52.682Z] E + where <function lint_metrics at 0x7f5379d36dc0> = lint.lint_metrics
[task 2024-09-03T18:59:52.683Z] E + and {'privacy.sanitize': {'clear': <glean_parser.metrics.Event object at 0x7f537864b5e0>, 'clearing_time_span_selected': <glean_parser.metrics.Event...
[task 2024-09-03T18:59:52.689Z] WARNING: EXPIRED: networking.set_cookie_expired_without_server_time: Metric has expired. Please consider removing it.
[task 2024-09-03T18:59:52.689Z]
[task 2024-09-03T18:59:52.689Z] Please fix the above nits to continue.
[task 2024-09-03T18:59:52.689Z] To disable a check, add a `no_lint` parameter with a list of check names to disable.
[task 2024-09-03T18:59:52.689Z] This parameter can appear with each individual metric, or at the top-level to affect the entire file.
[task 2024-09-03T18:59:52.689Z]
[task 2024-09-03T18:59:52.689Z] ============================== 1 failed in 5.28s ===============================
[task 2024-09-03T18:59:52.689Z]
[task 2024-09-03T18:59:52.689Z]
[task 2024-09-03T18:59:52.689Z] Tests Completed: 100%|██████████| 7/7 [00:07<00:00, 1.04s/Test]Return code from mach python-test: 1
[task 2024-09-03T18:59:52.715Z]
[taskcluster 2024-09-03 18:59:53.097Z] === Task Finished ===
[taskcluster 2024-09-03 18:59:53.098Z] Unsuccessful task run with exit code: 1 completed in 193.21 seconds
Comment 1•2 months ago
|
||
This appeared after this merge back
Comment 2•2 months ago
|
||
That's networking.set_cookie_expired_without_server_time
.
Defined here: https://searchfox.org/mozilla-central/rev/82ce14a9dc278584b868b2b9c252ba0871a7782b/netwerk/metrics.yaml#341-353
Landed 2 days ago.
We run expiry checks ... on Wednesday, so I expect a bug for this to be auto-created by tomorrow, but we have this now, so moving to the right component and tagging people.
Updated•2 months ago
|
Comment hidden (Intermittent Failures Robot) |
Updated•2 months ago
|
Comment 4•2 months ago
|
||
Set release status flags based on info from the regressing bug 1909980
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•2 months ago
|
Comment 9•2 months ago
|
||
Comment on attachment 9423867 [details]
short-data-request.txt
Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?
Yes.
Is the data collection covered by the existing Firefox Privacy Notice?
Yes.
Result: datareview+
Comment 10•2 months ago
|
||
Comment 11•1 months ago
|
||
bugherder |
Comment 12•1 months ago
|
||
This failure is still present if you could take a look.
Comment hidden (Intermittent Failures Robot) |
Description
•