1916532 - Remove or update metrics expiring in Firefox 132: networking.set_cookie_expired_without_server_time

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Treeherder Bug Filer]

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=472754354&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OpqyNtyZQV2np6E_HA-K3A/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-09-03T18:59:47.385Z] toolkit/components/glean/tests/pytest/test_jogfile_output.py::test_jogfile_output PASSED
[task 2024-09-03T18:59:47.385Z] 
[task 2024-09-03T18:59:47.385Z] ============================== 1 passed in 0.18s ===============================
[task 2024-09-03T18:59:47.385Z] 
[task 2024-09-03T18:59:47.385Z] 
[task 2024-09-03T18:59:52.670Z] Tests Completed:  86%|████████▌ | 6/7 [00:01<00:00,  3.53Test/s]
[task 2024-09-03T18:59:52.670Z]                                                                 
[task 2024-09-03T18:59:52.671Z] Setting retcode to 1 from /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_no_expired_metrics.py
[task 2024-09-03T18:59:52.671Z] 
[task 2024-09-03T18:59:52.671Z] Tests Completed: 100%|██████████| 7/7 [00:07<00:00,  1.47s/Test]
[task 2024-09-03T18:59:52.671Z]                                                                 
[task 2024-09-03T18:59:52.671Z] /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_no_expired_metrics.py
[task 2024-09-03T18:59:52.671Z] ============================= test session starts ==============================
[task 2024-09-03T18:59:52.671Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.5.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2024-09-03T18:59:52.671Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2024-09-03T18:59:52.671Z] plugins: mock-3.12.0
[task 2024-09-03T18:59:52.671Z] collecting ... collected 1 item
[task 2024-09-03T18:59:52.671Z] 
[task 2024-09-03T18:59:52.671Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py::test_no_metrics_expired TEST-UNEXPECTED-FAIL
[task 2024-09-03T18:59:52.671Z] 
[task 2024-09-03T18:59:52.671Z] =================================== FAILURES ===================================
[task 2024-09-03T18:59:52.672Z] ___________________________ test_no_metrics_expired ____________________________
[task 2024-09-03T18:59:52.672Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py:42: in test_no_metrics_expired
[task 2024-09-03T18:59:52.672Z]     assert not lint.lint_metrics(all_objs.value, options)
[task 2024-09-03T18:59:52.672Z] E   AssertionError: assert not [<glean_parser.lint.GlinterNit object at 0x7f5373fb67f0>]
[task 2024-09-03T18:59:52.673Z] E    +  where [<glean_parser.lint.GlinterNit object at 0x7f5373fb67f0>] = <function lint_metrics at 0x7f5379d36dc0>({'privacy.sanitize': {'clear': <glean_parser.metrics.Event...
[task 2024-09-03T18:59:52.682Z] E    +    where <function lint_metrics at 0x7f5379d36dc0> = lint.lint_metrics
[task 2024-09-03T18:59:52.683Z] E    +    and   {'privacy.sanitize': {'clear': <glean_parser.metrics.Event object at 0x7f537864b5e0>, 'clearing_time_span_selected': <glean_parser.metrics.Event...
[task 2024-09-03T18:59:52.689Z] WARNING: EXPIRED: networking.set_cookie_expired_without_server_time: Metric has expired. Please consider removing it.
[task 2024-09-03T18:59:52.689Z] 
[task 2024-09-03T18:59:52.689Z] Please fix the above nits to continue.
[task 2024-09-03T18:59:52.689Z] To disable a check, add a `no_lint` parameter with a list of check names to disable.
[task 2024-09-03T18:59:52.689Z] This parameter can appear with each individual metric, or at the top-level to affect the entire file.
[task 2024-09-03T18:59:52.689Z] 
[task 2024-09-03T18:59:52.689Z] ============================== 1 failed in 5.28s ===============================
[task 2024-09-03T18:59:52.689Z] 
[task 2024-09-03T18:59:52.689Z] 
[task 2024-09-03T18:59:52.689Z] Tests Completed: 100%|██████████| 7/7 [00:07<00:00,  1.04s/Test]Return code from mach python-test: 1
[task 2024-09-03T18:59:52.715Z] 
[taskcluster 2024-09-03 18:59:53.097Z] === Task Finished ===
[taskcluster 2024-09-03 18:59:53.098Z] Unsuccessful task run with exit code: 1 completed in 193.21 seconds

Comment 1

[Norisz Fay [:noriszfay]]

This appeared after this merge back

Comment 2

[Jan-Erik Rediger [:janerik]]

That's networking.set_cookie_expired_without_server_time.
Defined here: https://searchfox.org/mozilla-central/rev/82ce14a9dc278584b868b2b9c252ba0871a7782b/netwerk/metrics.yaml#341-353
Landed 2 days ago.
We run expiry checks ... on Wednesday, so I expect a bug for this to be auto-created by tomorrow, but we have this now, so moving to the right component and tagging people.

Comment 3

[Intermittent Failures Robot]

18 failures in 818 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64: 14
  • opt: 14
• macosx1015-64: 2
  • opt: 2
• windows11-64: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916532&startday=2024-09-04&endday=2024-09-04&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909980

Comment 5

[Intermittent Failures Robot]

41 failures in 3668 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 11
• autoland: 30

Platform and build breakdown:

• linux1804-64: 22
  • opt: 22
• macosx1015-64: 14
  • opt: 14
• windows11-64: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916532&startday=2024-09-02&endday=2024-09-08&tree=all

Comment 6

[Intermittent Failures Robot]

20 failures in 773 pushes (0.026 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 20

Platform and build breakdown:

• linux1804-64: 16
  • opt: 16
• macosx1015-64: 2
  • opt: 2
• windows11-64: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916532&startday=2024-09-09&endday=2024-09-09&tree=all

Comment 7

[edgul]

Attachment: short-data-request.txt

Comment 8

[edgul]

Attachment: Bug 1916532 - Extend metrics for set_cookie_expired_without_server_time to 138. r?baku

Comment 9

[[e-mail]]

Comment on attachment 9423867 [details]
short-data-request.txt

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---

Result: datareview+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d99eb0675264
Extend metrics for set_cookie_expired_without_server_time to 138. r=baku

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d99eb0675264

Comment 12

[Norisz Fay [:noriszfay]]

This failure is still present if you could take a look.

Comment 13

[Jan-Erik Rediger [:janerik]]

That was fixed in bug 1913382.

Comment 14

[Intermittent Failures Robot]

35 failures in 4448 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 27
• mozilla-release: 2
• mozilla-beta: 1
• mozilla-central: 5

Platform and build breakdown:

• linux1804-64: 20
  • opt: 20
• macosx1015-64: 6
  • opt: 6
• windows11-64: 5
  • opt: 5
• windows11-64-2009-asan-qr: 3
  • opt: 3
• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1916532&startday=2024-09-09&endday=2024-09-15&tree=all