1916601 - Allow caching the PerformanceTimingData for subsequent cached loads

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, task)

Description

[Tooru Fujisawa [:arai]]

SharedSubResourceCache implements in-process cache for the necko's response.
If the cache is used, the fetch operation doesn't reach necko.

Currently the PerformanceResourceTiming entry for the fetch is created and added as a part of HttpBaseChannel implementation, which means if SharedSubResourceCache is used, the corresponding PerformanceResourceTiming entry is not created (bug 1899734).

In order to create a PerformanceResourceTiming entry for the cached case, a part of PerformanceResourceTiming should be cached by SharedSubResourceCache. The cached data includes the server response etc, but not including the local timing data.

It can be achieved by splitting the cacheable fields out of mozilla::dom::PerformanceTimingData into a super class (let's say CacheablePerformanceTimingData), and cache the super class in SharedSubResourceCache, and generate a new PerformanceTiming from the
CacheablePerformanceTimingData and the timing data.

Comment 1

[Tooru Fujisawa [:arai]]

mozilla::dom::PerformanceTimingData::mBodyInfoAccessAllowed and mozilla::dom::PerformanceTimingData::mTimingAllowed fields are dynamically calculated based on principal, but I'm going to cache the result given the SharedSubResourceCache's cache is also separated for each principal.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916601 - Part 1: Split cacheable fields of PerformanceTimingData into CacheablePerformanceTimingData. r?sefeng!

Bug 1899734 is going to cache the performance timing data from previous fetch
for the subsequent cached fetch.
All non-timing-related fields associated with the response are moved to
CacheablePerformanceTimingData.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916601 - Part 2: Allow constructing PerformanceTimingData from CacheablePerformanceTimingData and timing data. r?sefeng!

Also make it possible to construct CacheablePerformanceTimingData from channels
to create a cache.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09c2b07d57ee
Part 1: Split cacheable fields of PerformanceTimingData into CacheablePerformanceTimingData. r=sefeng
https://hg.mozilla.org/integration/autoland/rev/7dbb2b29f8e5
Part 2: Allow constructing PerformanceTimingData from CacheablePerformanceTimingData and timing data. r=sefeng

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/09c2b07d57ee
https://hg.mozilla.org/mozilla-central/rev/7dbb2b29f8e5