1916605 - Markup view toggle buttons color doesn't adapt in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Markup view toggle button

See screenshot (I modified the color variables to highlight that those colors don't adapt to HCM)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916605 - [devtools] Make theme-twisty suitable for High Contrast Mode. r=#devtools-reviewers,#accessibility-frontend-reviewers.

Instead of setting the fill property to the desired color, we set the color
property, and then use currentColor for fill.
This way, when HCM forces the color of the text, the svg icon will get the expected color

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nchevobbe, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c81c9df649ea
[devtools] Make theme-twisty suitable for High Contrast Mode. r=devtools-reviewers,accessibility-frontend-reviewers,ochameau,nlapre.

Comment 5

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c81c9df649ea