1916656 - Breadcrumb separator icon color does not adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

We're actually not setting a color in CSS, so the color comes directly from the SVG itself

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 4

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916656 - [devtools] Adapt breadcrumb divider for High Contrast Mode. r=#devtools-reviewers.

The SVG itself is simplified to only take a solid color since that's the case
for all of other icons.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a15a6ca0664a
[devtools] Adapt breadcrumb divider for High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_inspector_breadcrumbs_keybinding.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a9196dfe2a290e29ed05e46ef076c762a1946fa0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=446f010a8fba5ea1502694249b118e988a294127&selectedTaskRun=Q-qtN-CLRMaQlIxka26L2w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=480293024&repo=autoland&lineNumber=2743

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6dca8874c36
[devtools] Adapt breadcrumb divider for High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 9

[amarc]

Backed out for causing dt failures @ browser_inspector_delete-selected-node-02.js.

• Backout link
• Push with failures
• Failure Log
• Failure snippet:

[task 2024-10-30T08:47:19.357Z] 08:47:19     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | The right node is selected - 
[task 2024-10-30T08:47:19.358Z] 08:47:19     INFO - Buffered messages finished
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:140 - TypeError: can't access property "textContent", breadcrumbs.querySelector(...) is null
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - Stack trace:
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - assertNodeSelectedAndPanelsUpdated@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:140:19
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*testManuallyDeleteSelectedNode@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:31:11
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js:15:9
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-30T08:47:19.359Z] 08:47:19     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-30T08:47:19.360Z] 08:47:19     INFO - Leaving test bound 
[task 2024-10-30T08:47:19.361Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Async method failed in safeAsyncMethod" (new Error("Connection closed, pending request to server0.conn0.process34//layout56, type getGrids failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:299:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19\ngetAllGrids@resource://devtools/client/fronts/layout.js:173:17\nexports.safeAsyncMethod/<@resource://devtools/shared/async-utils.js:61:25\ngetGrids@resource://devtools/client/inspector/grids/grid-inspector.js:450:35\nasync*onReflow@resource://devtools/client/inspector/grids/grid-inspector.js:544:40\nthrottledFunction@resource://devtools/shared/throttle.js:50:21\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nonReflowInSelection@resource://devtools/client/inspector/inspector.js:1614:10\n_forwardExistingResources@resource://devtools/shared/commands/resource/resource-command.js:1078:13\nwatchResources@resource://devtools/shared/commands/resource/resource-command.js:264:18\nasync*trackReflowsInSelection@resource://devtools/client/inspector/inspector.js:1581:43\nonNewSelection@resource://devtools/client/inspector/inspector.js:1554:10\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nsetNodeFront@resource://devtools/client/framework/selection.js:213:10\n_markContainerAsSelected@resource://devtools/client/inspector/markup/markup.js:2137:32\nnavigate@resource://devtools/client/inspector/markup/markup.js:1471:10\ndeleteNode/</</<@resource://devtools/client/inspector/markup/markup.js:1406:22\n", "resource://devtools/shared/protocol/Front.js", 105))
[task 2024-10-30T08:47:19.363Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Async method failed in safeAsyncMethod" (new Error("Connection closed, pending request to server0.conn0.process34//layout59, type getGrids failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:299:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19\ngetAllGrids@resource://devtools/client/fronts/layout.js:173:17\nexports.safeAsyncMethod/<@resource://devtools/shared/async-utils.js:61:25\ngetGrids@resource://devtools/client/inspector/grids/grid-inspector.js:450:35\nasync*onReflow@resource://devtools/client/inspector/grids/grid-inspector.js:544:40\nthrottledFunction@resource://devtools/shared/throttle.js:50:21\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nonReflowInSelection@resource://devtools/client/inspector/inspector.js:1614:10\n_forwardExistingResources@resource://devtools/shared/commands/resource/resource-command.js:1078:13\nwatchResources@resource://devtools/shared/commands/resource/resource-command.js:264:18\nasync*trackReflowsInSelection@resource://devtools/client/inspector/inspector.js:1581:43\nonNewSelection@resource://devtools/client/inspector/inspector.js:1554:10\n_emit@resource://devtools/shared/event-emitter.js:242:32\nemit@resource://devtools/shared/event-emitter.js:186:18\nemit@resource://devtools/shared/event-emitter.js:330:18\nsetNodeFront@resource://devtools/client/framework/selection.js:213:10\n_markContainerAsSelected@resource://devtools/client/inspector/markup/markup.js:2137:32\nnavigate@resource://devtools/client/inspector/markup/markup.js:1471:10\ndeleteNode/</</<@resource://devtools/client/inspector/markup/markup.js:1406:22\n", "resource://devtools/shared/protocol/Front.js", 105))
[task 2024-10-30T08:47:19.554Z] 08:47:19     INFO - GECKO(1889) | console.warn: "Inspector destroyed while executing onReflow callback"
[task 2024-10-30T08:47:19.555Z] 08:47:19     INFO - Removing tab.
[task 2024-10-30T08:47:19.556Z] 08:47:19     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2024-10-30T08:47:19.577Z] 08:47:19     INFO - Got event: 'TabClose' on [object XULElement].
[task 2024-10-30T08:47:19.613Z] 08:47:19     INFO - Tab removed and finished closing
[task 2024-10-30T08:47:19.628Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.633Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.637Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.638Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.639Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.640Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.641Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.641Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.642Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.643Z] 08:47:19     INFO - GECKO(1889) | JavaScript error: , line 0: NotFoundError: No such JSProcessActor 'DevToolsProcess'
[task 2024-10-30T08:47:19.669Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.672Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.675Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.677Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.678Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.680Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.680Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.681Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.681Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.683Z] 08:47:19     INFO - Console message: [JavaScript Error: "NotFoundError: No such JSProcessActor 'DevToolsProcess'"]
[task 2024-10-30T08:47:19.683Z] 08:47:19     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2024-10-30T08:47:20.000Z] 08:47:20     INFO - GECKO(1889) | MEMORY STAT | vsize 20984532MB | residentFast 1613MB
[task 2024-10-30T08:47:20.002Z] 08:47:20     INFO - TEST-OK | devtools/client/inspector/test/browser_inspector_delete-selected-node-02.js | took 4936ms
[task 2024-10-30T08:47:20.047Z] 08:47:20     INFO - checking window state
[task 2024-10-30T08:47:20.091Z] 08:47:20     INFO - TEST-START | devtools/client/inspector/test/browser_inspector_delete-selected-node-03.js

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da9e5676ec89
[devtools] Adapt breadcrumb divider for High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/da9e5676ec89