1916669 - Rules view accordion text isn't legible on hover in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Rules view toggle button

See screenshot (I tweaked the base variable colors so it's easier to spot)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Note that this also impact the layout panel

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 5

[Anna Yeddi [:ayeddi]]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

The toggle adapts fine now, but the text is not legible on hover

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916669 - [devtools] Don't use --theme-accordion-header-background on elements that are not accordion headers. r=#devtools.

This adds a new variable with the same colors than the variable one that we can use as a drop-in replacement.
For some cases, we could reuse the existing --theme-body-emphasized-background.
The Debugger ResultList style could be simplified as it should always have either 'small' or 'big' class, which
were both setting a background color for selected item, overriding the declaration that was using --theme-accordion-header-background.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916669 - [devtools] Adapt Accordion headers in High Contrast Mode. r=#devtools.

Adapt the color of the text and arrow, especially on hover.
This covers accordion in the rules view, the layout panel and the debugger.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a4b66196f17
[devtools] Don't use --theme-accordion-header-background on elements that are not accordion headers. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/8188ec57dcc1
[devtools] Adapt Accordion headers in High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9a4b66196f17
https://hg.mozilla.org/mozilla-central/rev/8188ec57dcc1